linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: YueHaibing <yuehaibing@huawei.com>
Cc: <knaack.h@gmx.de>, <lars@metafoo.de>, <pmeerw@pmeerw.net>,
	<gregkh@linuxfoundation.org>, <tglx@linutronix.de>,
	<denis.ciocca@st.com>, <Jonathan.Cameron@huawei.com>,
	<linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] iio: st_sensors: Fix build error
Date: Sun, 25 Aug 2019 18:59:36 +0100	[thread overview]
Message-ID: <20190825185936.0b31cde6@archlinux> (raw)
In-Reply-To: <20190823121852.75108-1-yuehaibing@huawei.com>

On Fri, 23 Aug 2019 20:18:52 +0800
YueHaibing <yuehaibing@huawei.com> wrote:

> IIO_ST_SENSORS_CORE select IIO_ST_SENSORS_I2C
> unconditionally, if REGMAP_I2C is not set, build fails
> 
> drivers/iio/common/st_sensors/st_sensors_i2c.o: In function `st_sensors_i2c_configure':
> st_sensors_i2c.c:(.text+0x58): undefined reference to `__devm_regmap_init_i2c'
> 
> This patch selects REGMAP_I2C to fix it.
> IIO_ST_SENSORS_SPI is similar to SPI issue.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 062809ef7733 ("iio: make st_sensors drivers use regmap")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Hi,

Thanks,  I've fixed up the inconsistent ordering below.

Applied to the togreg branch of iio.git and pushed out as
testing for the autobuilders to play with it.

Thanks,

Jonathan

> ---
>  drivers/iio/common/st_sensors/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/iio/common/st_sensors/Kconfig b/drivers/iio/common/st_sensors/Kconfig
> index 91b98e1..16d973f 100644
> --- a/drivers/iio/common/st_sensors/Kconfig
> +++ b/drivers/iio/common/st_sensors/Kconfig
> @@ -5,8 +5,10 @@
>  
>  config IIO_ST_SENSORS_I2C
>  	tristate
> +	select REGMAP_I2C
>  
>  config IIO_ST_SENSORS_SPI
> +	select REGMAP_SPI

Inconsistent with the previous.

>  	tristate
>  
>  config IIO_ST_SENSORS_CORE


  reply	other threads:[~2019-08-25 17:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-23 12:18 [PATCH -next] iio: st_sensors: Fix build error YueHaibing
2019-08-25 17:59 ` Jonathan Cameron [this message]
2019-08-26  2:48   ` Yuehaibing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190825185936.0b31cde6@archlinux \
    --to=jic23@kernel.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=denis.ciocca@st.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=tglx@linutronix.de \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).