From: Jonathan Cameron <jic23@kernel.org>
To: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
Cc: "matt.ranostay@konsulko.com" <matt.ranostay@konsulko.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: [PATCH] iio: hdc100x: fix iio_triggered_buffer_{predisable,postenable} positions
Date: Sat, 2 Nov 2019 14:40:41 +0000 [thread overview]
Message-ID: <20191102144041.2c8bc85d@archlinux> (raw)
In-Reply-To: <46d418bd0546c98e22a0d331741c053274c2170f.camel@analog.com>
On Mon, 28 Oct 2019 07:11:51 +0000
"Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote:
> On Sun, 2019-10-27 at 20:37 +0200, Matt Ranostay wrote:
> > [External]
> >
> > On Sun, Oct 27, 2019 at 6:58 PM Jonathan Cameron <jic23@kernel.org>
> > wrote:
> > > On Wed, 23 Oct 2019 11:27:14 +0300
> > > Alexandru Ardelean <alexandru.ardelean@analog.com> wrote:
> > >
> > > > The iio_triggered_buffer_postenable() hook should be called first to
> > > > attach the poll function and the iio_triggered_buffer_predisable()
> > > > hook
> > > > should be called last in the predisable hook.
> > > >
> > > > This change updates the driver to attach/detach the poll func in the
> > > > correct order.
> > > >
> > > > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> > > Seems fine, but should have cc'd Matt and I'd like to give him time
> > > to take a quick look.
> > >
> >
> > Reviewed-by: Matt Ranostay <matt.ranostay@konsulko.com>
>
> Apologies for not CC-ing Matt.
> I guess I wasn't paying [close enough] attention to the output of
> get_maintainers.pl
>
> Thanks
> Alex
>
Applied to the togreg branch of iio.git and pushed out as testing for the
autobuilders to play with it.
Thanks,
Jonathan
> >
> > > +CC Matt.
> > >
> > > Thanks,
> > >
> > > Jonathan
> > >
> > > > ---
> > > > drivers/iio/humidity/hdc100x.c | 19 +++++++++++--------
> > > > 1 file changed, 11 insertions(+), 8 deletions(-)
> > > >
> > > > diff --git a/drivers/iio/humidity/hdc100x.c
> > > > b/drivers/iio/humidity/hdc100x.c
> > > > index bfe1cdb16846..963ff043eecf 100644
> > > > --- a/drivers/iio/humidity/hdc100x.c
> > > > +++ b/drivers/iio/humidity/hdc100x.c
> > > > @@ -278,31 +278,34 @@ static int hdc100x_buffer_postenable(struct
> > > > iio_dev *indio_dev)
> > > > struct hdc100x_data *data = iio_priv(indio_dev);
> > > > int ret;
> > > >
> > > > + ret = iio_triggered_buffer_postenable(indio_dev);
> > > > + if (ret)
> > > > + return ret;
> > > > +
> > > > /* Buffer is enabled. First set ACQ Mode, then attach poll func
> > > > */
> > > > mutex_lock(&data->lock);
> > > > ret = hdc100x_update_config(data, HDC100X_REG_CONFIG_ACQ_MODE,
> > > > HDC100X_REG_CONFIG_ACQ_MODE);
> > > > mutex_unlock(&data->lock);
> > > > if (ret)
> > > > - return ret;
> > > > + iio_triggered_buffer_predisable(indio_dev);
> > > >
> > > > - return iio_triggered_buffer_postenable(indio_dev);
> > > > + return ret;
> > > > }
> > > >
> > > > static int hdc100x_buffer_predisable(struct iio_dev *indio_dev)
> > > > {
> > > > struct hdc100x_data *data = iio_priv(indio_dev);
> > > > - int ret;
> > > > -
> > > > - /* First detach poll func, then reset ACQ mode. OK to disable
> > > > buffer */
> > > > - ret = iio_triggered_buffer_predisable(indio_dev);
> > > > - if (ret)
> > > > - return ret;
> > > > + int ret, ret2;
> > > >
> > > > mutex_lock(&data->lock);
> > > > ret = hdc100x_update_config(data, HDC100X_REG_CONFIG_ACQ_MODE,
> > > > 0);
> > > > mutex_unlock(&data->lock);
> > > >
> > > > + ret2 = iio_triggered_buffer_predisable(indio_dev);
> > > > + if (ret == 0)
> > > > + ret = ret2;
> > > > +
> > > > return ret;
> > > > }
> > > >
prev parent reply other threads:[~2019-11-02 14:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 8:27 [PATCH] iio: hdc100x: fix iio_triggered_buffer_{predisable,postenable} positions Alexandru Ardelean
2019-10-27 16:58 ` Jonathan Cameron
2019-10-27 18:37 ` Matt Ranostay
2019-10-28 7:11 ` Ardelean, Alexandru
2019-11-02 14:40 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191102144041.2c8bc85d@archlinux \
--to=jic23@kernel.org \
--cc=alexandru.Ardelean@analog.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.ranostay@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).