From: Jonathan Cameron <jic23@kernel.org>
To: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
Cc: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"manabian@gmail.com" <manabian@gmail.com>,
"Jonathan.Cameron@huawei.com" <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH] iio: dac: lpc18xx: Use devm_platform_ioremap_resource
Date: Sat, 9 Nov 2019 12:30:55 +0000 [thread overview]
Message-ID: <20191109123055.156de624@archlinux> (raw)
In-Reply-To: <a26444c26603137a293dae3c84147f8e727ce198.camel@analog.com>
On Mon, 4 Nov 2019 15:16:44 +0000
"Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote:
> On Sun, 2019-10-13 at 18:14 +0100, jic23@kernel.org wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
> > Reduce boilerplate.
> > Suggested by coccinelle
> > CHECK drivers/iio/dac/lpc18xx_dac.c
> > drivers/iio/dac/lpc18xx_dac.c:121:1-10: WARNING: Use
> > devm_platform_ioremap_resource for dac -> base
> >
>
> Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
>
Applied,
Thanks,
J
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > CC: Joachim Eastwood <manabian@gmail.com>
> > ---
> > drivers/iio/dac/lpc18xx_dac.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/iio/dac/lpc18xx_dac.c
> > b/drivers/iio/dac/lpc18xx_dac.c
> > index 883e84e96609..0ab357bd3633 100644
> > --- a/drivers/iio/dac/lpc18xx_dac.c
> > +++ b/drivers/iio/dac/lpc18xx_dac.c
> > @@ -106,7 +106,6 @@ static int lpc18xx_dac_probe(struct platform_device
> > *pdev)
> > {
> > struct iio_dev *indio_dev;
> > struct lpc18xx_dac *dac;
> > - struct resource *res;
> > int ret;
> >
> > indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(*dac));
> > @@ -117,8 +116,7 @@ static int lpc18xx_dac_probe(struct platform_device
> > *pdev)
> > dac = iio_priv(indio_dev);
> > mutex_init(&dac->lock);
> >
> > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > - dac->base = devm_ioremap_resource(&pdev->dev, res);
> > + dac->base = devm_platform_ioremap_resource(pdev, 0);
> > if (IS_ERR(dac->base))
> > return PTR_ERR(dac->base);
> >
prev parent reply other threads:[~2019-11-09 12:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-13 17:14 [PATCH] iio: dac: lpc18xx: Use devm_platform_ioremap_resource jic23
2019-11-04 15:16 ` Ardelean, Alexandru
2019-11-09 12:30 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191109123055.156de624@archlinux \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=alexandru.Ardelean@analog.com \
--cc=linux-iio@vger.kernel.org \
--cc=manabian@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).