From: Jonathan Cameron <jic23@kernel.org>
To: Rohit Sarkar <rohitsarkar5398@gmail.com>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
alexandru.Ardelean@analog.com, dragos.bogdan@analog.com,
Matt Ranostay <matt.ranostay@konsulko.com>
Subject: Re: [PATCH v2] iio: health: max30100: use generic property handler
Date: Sun, 22 Mar 2020 17:50:42 +0000 [thread overview]
Message-ID: <20200322175042.7903862d@archlinux> (raw)
In-Reply-To: <5e6e48dd.1c69fb81.11507.523e@mx.google.com>
On Sun, 15 Mar 2020 20:55:12 +0530
Rohit Sarkar <rohitsarkar5398@gmail.com> wrote:
> Instead of of_property_read_xxx use device_property_read_xxx as it is
> compatible with ACPI too as opposed to only device tree.
>
> Signed-off-by: Rohit Sarkar <rohitsarkar5398@gmail.com>
Looks good to me.
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with them.
Thanks,
Jonathan
> ---
> Changelog
> v1 -> v2
> - remove of_match_ptr to make it possible to use PRP0001 ACPI based
> bindings
> drivers/iio/health/max30100.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iio/health/max30100.c b/drivers/iio/health/max30100.c
> index 84010501762d..546fc37ad75d 100644
> --- a/drivers/iio/health/max30100.c
> +++ b/drivers/iio/health/max30100.c
> @@ -16,7 +16,7 @@
> #include <linux/irq.h>
> #include <linux/i2c.h>
> #include <linux/mutex.h>
> -#include <linux/of.h>
> +#include <linux/property.h>
> #include <linux/regmap.h>
> #include <linux/iio/iio.h>
> #include <linux/iio/buffer.h>
> @@ -267,11 +267,10 @@ static int max30100_get_current_idx(unsigned int val, int *reg)
> static int max30100_led_init(struct max30100_data *data)
> {
> struct device *dev = &data->client->dev;
> - struct device_node *np = dev->of_node;
> unsigned int val[2];
> int reg, ret;
>
> - ret = of_property_read_u32_array(np, "maxim,led-current-microamp",
> + ret = device_property_read_u32_array(dev, "maxim,led-current-microamp",
> (unsigned int *) &val, 2);
> if (ret) {
> /* Default to 24 mA RED LED, 50 mA IR LED */
> @@ -502,7 +501,7 @@ MODULE_DEVICE_TABLE(of, max30100_dt_ids);
> static struct i2c_driver max30100_driver = {
> .driver = {
> .name = MAX30100_DRV_NAME,
> - .of_match_table = of_match_ptr(max30100_dt_ids),
> + .of_match_table = max30100_dt_ids,
> },
> .probe = max30100_probe,
> .remove = max30100_remove,
prev parent reply other threads:[~2020-03-22 17:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-15 15:25 [PATCH v2] iio: health: max30100: use generic property handler Rohit Sarkar
2020-03-22 17:50 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200322175042.7903862d@archlinux \
--to=jic23@kernel.org \
--cc=alexandru.Ardelean@analog.com \
--cc=dragos.bogdan@analog.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.ranostay@konsulko.com \
--cc=rohitsarkar5398@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).