From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Mike Looijmans <mike.looijmans@topic.nl>
Cc: Jonathan Cameron <jic23@kernel.org>, <devicetree@vger.kernel.org>,
<linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<knaack.h@gmx.de>, <lars@metafoo.de>, <pmeerw@pmeerw.net>,
<robh+dt@kernel.org>, <mark.rutland@arm.com>
Subject: Re: [PATCH] dt-bindings: iio: accel: Add bmi088 accelerometer bindings
Date: Mon, 23 Mar 2020 16:41:02 +0000 [thread overview]
Message-ID: <20200323164102.00005abb@Huawei.com> (raw)
In-Reply-To: <d9105fb7-fe0b-d432-fb12-d595c364f83b@topic.nl>
On Mon, 23 Mar 2020 10:56:41 +0100
Mike Looijmans <mike.looijmans@topic.nl> wrote:
> On 22-03-2020 18:37, Jonathan Cameron wrote:
> > On Mon, 16 Mar 2020 07:52:18 +0100
> > Mike Looijmans <mike.looijmans@topic.nl> wrote:
> >
> >> This adds the device-tree bindings for the Bosch Sensortec BMI088 IMU,
> >> the accelerometer part.
> >>
> >> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
> >> ---
> >> .../devicetree/bindings/iio/accel/bmi088.txt | 23 +++++++++++++++++++
> >
> > Sorry. All new DT bindings need to be in yaml format.
> >
> > Please put this in the same series as the driver.
>
> sooy, I noticed this too late, patches are underway in separate mails
> now. Hope that isn't a blocking issue?
For next version of either pull them together.
Jonathan
>
> >
> > Thanks,
> >
> > Jonathan
> >
> >> 1 file changed, 23 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/iio/accel/bmi088.txt
> >>
> >> diff --git a/Documentation/devicetree/bindings/iio/accel/bmi088.txt b/Documentation/devicetree/bindings/iio/accel/bmi088.txt
> >> new file mode 100644
> >> index 000000000000..691a47726dbc
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/iio/accel/bmi088.txt
> >> @@ -0,0 +1,23 @@
> >> +* Bosch BMI088 IMU combining accelerometer and gyroscope
> >> +
> >> +https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bmi088-ds001.pdf
> >> +
> >> +Required properties:
> >> +
> >> + - compatible : should be "bosch,bmi088_accel"
> >> + - reg : the I2C address of the sensor or the SPI chip select number
> >> +
> >> +Optional properties:
> >> +
> >> + - interrupts : interrupt mapping for GPIO IRQ, it should be configured with
> >> + IRQ_TYPE_EDGE_RISING
> >> +
> >> +Example:
> >> +
> >> +bmi088_accel@1 {
> >> + compatible = "bosch,bmi088_accel";
> >> + reg = <1>;
> >> + spi-max-frequency = <10000000>;
> >> + interrupt-parent = <&gpio>;
> >> + interrupts = <90 IRQ_TYPE_EDGE_RISING>;
> >> +};
> >
>
>
prev parent reply other threads:[~2020-03-23 16:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 6:52 [PATCH] dt-bindings: iio: accel: Add bmi088 accelerometer bindings Mike Looijmans
2020-03-22 17:37 ` Jonathan Cameron
2020-03-23 9:56 ` Mike Looijmans
2020-03-23 16:41 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200323164102.00005abb@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.looijmans@topic.nl \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).