From: Lee Jones <lee.jones@linaro.org>
To: saravanan sekar <sravanhome@gmail.com>
Cc: robh+dt@kernel.org, jic23@kernel.org, knaack.h@gmx.de,
lars@metafoo.de, pmeerw@pmeerw.net, sre@kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v4 2/5] mfd: mp2629: Add support for mps battery charger
Date: Fri, 27 Mar 2020 11:25:23 +0000 [thread overview]
Message-ID: <20200327112523.GC3383@dell> (raw)
In-Reply-To: <a679aba5-4cfb-1b6c-8cb0-dab3a644f3e7@gmail.com>
On Fri, 27 Mar 2020, saravanan sekar wrote:
> On 27/03/20 11:22 am, Lee Jones wrote:
> > Saravanan, Jonathan,
> >
> > On Fri, 27 Mar 2020, saravanan sekar wrote:
> > > On 27/03/20 8:55 am, Lee Jones wrote:
> > > > On Sun, 22 Mar 2020, Saravanan Sekar wrote:
> > > >
> > > > > mp2629 is a highly-integrated switching-mode battery charge management
> > > > > device for single-cell Li-ion or Li-polymer battery.
> > > > >
> > > > > Add MFD core enables chip access for ADC driver for battery readings,
> > > > > and a power supply battery-charger driver
> > > > >
> > > > > Signed-off-by: Saravanan Sekar <sravanhome@gmail.com>
> > > > > ---
> > > > > drivers/mfd/Kconfig | 9 +++
> > > > > drivers/mfd/Makefile | 2 +
> > > > > drivers/mfd/mp2629.c | 116 +++++++++++++++++++++++++++++++++++++
> > > > > include/linux/mfd/mp2629.h | 22 +++++++
> > > > > 4 files changed, 149 insertions(+)
> > > > > create mode 100644 drivers/mfd/mp2629.c
> > > > > create mode 100644 include/linux/mfd/mp2629.h
[...]
> > > > > +#ifndef __MP2629_H__
> > > > > +#define __MP2629_H__
> > > > > +
> > > > > +#include <linux/types.h>
> > > > > +
> > > > > +struct device;
> > > > > +struct regmap;
> > > > Why not just add the includes?
> > > Some more shared enum added in ADC driver
> > Sorry?
>
> I misunderstood your previous question that you are asking to remove this
> mp2629.h file
>
> "No user here. (Hint: Use forward declaration of struct device instead)" -
> review comments on V1 from Andy Shevchenko.
> So remove the includes
So Andy has reviewed, but you still don't have him on Cc?
How are we meant to continue the discussion?
As a general rule I'm not a fan of forward declarations.
I think they should be avoided if at all possible.
> > > > > +struct mp2629_info {
> > > > > + struct device *dev;
> > > > > + struct regmap *regmap;
> > > > > +};
> > > > > +
> > > > > +#endif
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-03-27 11:24 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-22 22:46 [PATCH v4 0/5] Add battery charger driver support for MP2629 Saravanan Sekar
2020-03-22 22:46 ` [PATCH v4 1/5] dt-bindings: mfd: add document bindings for mp2629 Saravanan Sekar
2020-03-27 8:00 ` Lee Jones
2020-03-27 21:50 ` saravanan sekar
2020-03-30 6:46 ` Lee Jones
2020-04-07 16:29 ` saravanan sekar
2020-04-08 10:15 ` Lee Jones
2020-03-22 22:46 ` [PATCH v4 2/5] mfd: mp2629: Add support for mps battery charger Saravanan Sekar
2020-03-27 7:55 ` Lee Jones
2020-03-27 8:32 ` saravanan sekar
2020-03-27 10:22 ` Lee Jones
2020-03-27 10:56 ` saravanan sekar
2020-03-27 11:25 ` Lee Jones [this message]
2020-03-27 12:40 ` saravanan sekar
2020-03-27 12:56 ` Andy Shevchenko
2020-03-27 13:03 ` saravanan sekar
2020-03-27 13:17 ` Andy Shevchenko
2020-03-28 14:36 ` Jonathan Cameron
2020-03-22 22:46 ` [PATCH v4 3/5] iio: adc: mp2629: Add support for mp2629 ADC driver Saravanan Sekar
2020-03-22 23:32 ` Andy Shevchenko
2020-03-28 14:42 ` Jonathan Cameron
2020-03-28 18:50 ` Andy Shevchenko
2020-03-29 10:37 ` saravanan sekar
2020-03-29 11:09 ` Andy Shevchenko
2020-03-22 22:46 ` [PATCH v4 4/5] power: supply: Add support for mps mp2629 battery charger Saravanan Sekar
2020-03-22 23:26 ` Andy Shevchenko
2020-03-23 12:29 ` saravanan sekar
2020-03-22 22:46 ` [PATCH v4 5/5] MAINTAINERS: Add entry for mp2629 Battery Charger driver Saravanan Sekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200327112523.GC3383@dell \
--to=lee.jones@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=sravanhome@gmail.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).