From: Jonathan Cameron <jic23@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-iio <linux-iio@vger.kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Subject: Re: [PATCH v2 1/5] iio: pressure: bmp280: Tolerate IRQ before registering
Date: Sat, 28 Mar 2020 16:02:03 +0000 [thread overview]
Message-ID: <20200328160203.1d0e378b@archlinux> (raw)
In-Reply-To: <CACRpkdagNP6cY353oi0vCAihqvd2ZOHJ8Os7j-cq4EVBCC4+Ug@mail.gmail.com>
On Fri, 27 Mar 2020 11:50:25 +0100
Linus Walleij <linus.walleij@linaro.org> wrote:
> On Mon, Mar 23, 2020 at 11:41 AM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
>
> > With DEBUG_SHIRQ enabled we have a kernel crash
> >
> > [ 116.482696] BUG: kernel NULL pointer dereference, address: 0000000000000000
> >
> > ...
> >
> > [ 116.606571] Call Trace:
> > [ 116.609023] <IRQ>
> > [ 116.611047] complete+0x34/0x50
> > [ 116.614206] bmp085_eoc_irq+0x9/0x10 [bmp280]
> >
> > because DEBUG_SHIRQ mechanism fires an IRQ before registration and drivers
> > ought to be able to handle an interrupt happening before request_irq() returns.
> >
> > Fixes: aae953949651 ("iio: pressure: bmp280: add support for BMP085 EOC interrupt")
> > Cc: Linus Walleij <linus.walleij@linaro.org>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > v2: put conditional logic back when re-initializing completion (Jonathan)
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to poke at them.
Thanks,
Jonathan
>
> Yours,
> Linus Walleij
prev parent reply other threads:[~2020-03-28 16:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 10:41 [PATCH v2 1/5] iio: pressure: bmp280: Tolerate IRQ before registering Andy Shevchenko
2020-03-23 10:41 ` [PATCH v2 2/5] iio: pressure: bmp280: Convert to use ->read_avail() Andy Shevchenko
2020-03-23 10:41 ` [PATCH v2 3/5] iio: pressure: bmp280: Explicitly mark GPIO optional Andy Shevchenko
2020-03-23 10:41 ` [PATCH v2 4/5] iio: pressure: bmp280: Drop unneeded explicit castings Andy Shevchenko
2020-03-23 10:41 ` [PATCH v2 5/5] iio: pressure: bmp280: Join string literals back Andy Shevchenko
2020-03-27 10:50 ` [PATCH v2 1/5] iio: pressure: bmp280: Tolerate IRQ before registering Linus Walleij
2020-03-28 16:02 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200328160203.1d0e378b@archlinux \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).