From: Jonathan Albrieux <jonathan.albrieux@gmail.com>
To: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Cc: linux-kernel@vger.kernel.org,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
"open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@vger.kernel.org>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH v2 4/4] iio: imu: bmi160: added mount-matrix support
Date: Wed, 20 May 2020 09:20:16 +0200 [thread overview]
Message-ID: <20200520072016.GE3361@ict14-OptiPlex-980> (raw)
In-Reply-To: <20200519185711.00003308@Huawei.com>
On Tue, May 19, 2020 at 06:57:11PM +0100, Jonathan Cameron wrote:
> On Tue, 19 May 2020 09:51:00 +0200
> Jonathan Albrieux <jonathan.albrieux@gmail.com> wrote:
>
> > Add mount-matrix binding support. As chip could have different orientations
> > a mount matrix support is needed to correctly translate these differences
> >
> > Signed-off-by: Jonathan Albrieux <jonathan.albrieux@gmail.com>
> Hi Jonathan,
>
> Looks good to me. I'll pick this up once 1-3 are tidied up and
> we have a device tree review in for the binding doc. I'm rubbish
> at reviewing those as Rob will certify so may well have missed something!
>
> Jonathan
>
>
Thank you! I'm going to work on suggestions now,
Best regards,
Jonathan Albrieux
>
> > ---
> > drivers/iio/imu/bmi160/bmi160.h | 1 +
> > drivers/iio/imu/bmi160/bmi160_core.c | 20 ++++++++++++++++++++
> > 2 files changed, 21 insertions(+)
> >
> > diff --git a/drivers/iio/imu/bmi160/bmi160.h b/drivers/iio/imu/bmi160/bmi160.h
> > index 923c3b274fde..a82e040bd109 100644
> > --- a/drivers/iio/imu/bmi160/bmi160.h
> > +++ b/drivers/iio/imu/bmi160/bmi160.h
> > @@ -9,6 +9,7 @@ struct bmi160_data {
> > struct regmap *regmap;
> > struct iio_trigger *trig;
> > struct regulator_bulk_data supplies[2];
> > + struct iio_mount_matrix orientation;
> > };
> >
> > extern const struct regmap_config bmi160_regmap_config;
> > diff --git a/drivers/iio/imu/bmi160/bmi160_core.c b/drivers/iio/imu/bmi160/bmi160_core.c
> > index 9bbe0d8e6720..78c8ca962359 100644
> > --- a/drivers/iio/imu/bmi160/bmi160_core.c
> > +++ b/drivers/iio/imu/bmi160/bmi160_core.c
> > @@ -110,6 +110,7 @@
> > .storagebits = 16, \
> > .endianness = IIO_LE, \
> > }, \
> > + .ext_info = bmi160_ext_info, \
> > }
> >
> > /* scan indexes follow DATA register order */
> > @@ -265,6 +266,20 @@ static const struct bmi160_odr_item bmi160_odr_table[] = {
> > },
> > };
> >
> > +static const struct iio_mount_matrix *
> > +bmi160_get_mount_matrix(const struct iio_dev *indio_dev,
> > + const struct iio_chan_spec *chan)
> > +{
> > + struct bmi160_data *data = iio_priv(indio_dev);
> > +
> > + return &data->orientation;
> > +}
> > +
> > +static const struct iio_chan_spec_ext_info bmi160_ext_info[] = {
> > + IIO_MOUNT_MATRIX(IIO_SHARED_BY_DIR, bmi160_get_mount_matrix),
> > + { }
> > +};
> > +
> > static const struct iio_chan_spec bmi160_channels[] = {
> > BMI160_CHANNEL(IIO_ACCEL, X, BMI160_SCAN_ACCEL_X),
> > BMI160_CHANNEL(IIO_ACCEL, Y, BMI160_SCAN_ACCEL_Y),
> > @@ -840,6 +855,11 @@ int bmi160_core_probe(struct device *dev, struct regmap *regmap,
> > return ret;
> > }
> >
> > + ret = iio_read_mount_matrix(dev, "mount-matrix",
> > + &data->orientation);
> > + if (ret)
> > + return ret;
> > +
> > ret = bmi160_chip_init(data, use_spi);
> > if (ret)
> > return ret;
>
>
prev parent reply other threads:[~2020-05-20 7:20 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 7:50 [PATCH v2 0/4] iio: imu: bmi160: added regulator and mount-matrix support Jonathan Albrieux
2020-05-19 7:50 ` [PATCH v2 1/4] dt-bindings: iio: imu: bmi160: convert txt format to yaml Jonathan Albrieux
2020-05-19 17:37 ` Rob Herring
2020-05-20 7:06 ` Jonathan Albrieux
2020-05-19 17:49 ` Jonathan Cameron
2020-05-20 7:24 ` Jonathan Albrieux
2020-05-21 18:27 ` Jonathan Cameron
2020-05-22 8:22 ` Jonathan Albrieux
2020-05-22 10:47 ` Daniel Baluta
2020-05-22 14:26 ` Jonathan Albrieux
2020-05-22 14:59 ` Daniel Baluta
2020-05-22 15:44 ` Jonathan Albrieux
2020-05-19 18:20 ` Rob Herring
2020-05-20 7:29 ` Jonathan Albrieux
2020-05-19 7:50 ` [PATCH v2 2/4] dt-bindings: iio: imu: bmi160: add regulators and mount-matrix Jonathan Albrieux
2020-05-19 17:51 ` Jonathan Cameron
2020-05-20 7:11 ` Jonathan Albrieux
2020-05-19 7:50 ` [PATCH v2 3/4] iio: imu: bmi160: added regulator support Jonathan Albrieux
2020-05-19 17:55 ` Jonathan Cameron
2020-05-20 7:17 ` Jonathan Albrieux
2020-05-21 18:30 ` Jonathan Cameron
2020-05-22 8:25 ` Jonathan Albrieux
2020-05-19 7:51 ` [PATCH v2 4/4] iio: imu: bmi160: added mount-matrix support Jonathan Albrieux
2020-05-19 17:57 ` Jonathan Cameron
2020-05-20 7:20 ` Jonathan Albrieux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200520072016.GE3361@ict14-OptiPlex-980 \
--to=jonathan.albrieux@gmail.com \
--cc=Jonathan.Cameron@Huawei.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).