From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: linux-iio <linux-iio@vger.kernel.org>,
Alexandru Ardelean <alexandru.Ardelean@analog.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH 00/23] iio:adc more of_match_ptr and similar removal
Date: Sat, 4 Jul 2020 18:35:10 +0100 [thread overview]
Message-ID: <20200704183510.119e157a@archlinux> (raw)
In-Reply-To: <CAHp75VeXWF1VuWeh=-S26=zn8bqXRZFuvQxUEy8Ez8oxxrWAjQ@mail.gmail.com>
On Tue, 30 Jun 2020 10:27:49 +0300
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> On Sun, Jun 28, 2020 at 3:38 PM Jonathan Cameron <jic23@kernel.org> wrote:
> >
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
> > Continuation of slow process to try and remove use of of_match_ptr
> > to supress asignment of the of_device_id table when !CONFIG_OF.
> >
> > Usual argument that it prevents ACPI being used with these drivers
> > via PRP0001 in DSDT. Perhaps more usefully we are cutting down on the
> > number of places it can be cut and paste from into new drivers.
> >
> > This is just the low hanging fruit. I'm not yet sure if it makes
> > sense to expend the effort to use generic firmware properties etc
> > for some of the remaining drivers as it is unlikely they'll ever
> > be used with anything other than device tree. There are 4 current
> > ADC drivers in this more complex category.
>
> For the non-commented,
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>
> Commented with LGTM also can have Rb tag.
> The rest, please consider to address.
>
> Thanks for a nice clean up!
Thanks for your hard work going through all these.
I've applied all the good ones and will respin the others.
Thanks,
Jonathan
>
> >
> > Jonathan Cameron (23):
> > iio:adc:lpc32xx: Drop of_match_ptr protection
> > iio:adc:axp20x: Convert from OF to generic fw / device properties
> > iio:adc:hi8435: Drop unused of_gpio.h header
> > iio:adc:hi8435: Drop of_match_ptr protection.
> > iio:adc:max1363: Drop of_match_ptr and use generic
> > device_get_match_data
> > iio:adc:max1027: drop of_match_ptr and CONFIG_OF protections
> > iio:adc:ltc2496: Drop of_match_ptr and use mod_devicetable.h
> > iio:adc:cpcap-adc: Drop of_match_ptr protection and use
> > device_get_match_data
> > iio:adc:ltc2497 drop of_match_ptr protection
> > iio:adc:max11100: Drop of_match_ptr protection / add mod_devicetable.h
> > include
> > iio:adc:max1118: Drop CONFIG_OF / of_match_ptr protections
> > iio:adc:mcp320x: Drop CONFIG_OF and of_match_ptr protections
> > iio:adc:mcp3422: remove CONFIG_OF and of_match_ptr protections
> > iio:adc:sd_adc_modulator: Drop of_match_ptr and tweak includes
> > iio:adc:ti-adc081c: Drop of_match_ptr and change to mod_devicetable.h
> > iio:adc:ti-adc0832: drop CONFIG_OF and of_match_ptr protections
> > iio:adc:ti-adc084s021: drop of_match_ptr protection
> > iio:adc:ti-adc108s102: Drop CONFIG_OF and of_match_ptr protections
> > iio:adc:ti-adc128s052: drop of_match_ptr protection
> > iio:adc:ti-adc161s626: Drop of_match_ptr protection.
> > iio:adc:ti-tlc4541: Drop CONFIG_OF and of_match_ptr protections.
> > iio:adc:bcm_iproc: Drop of_match_ptr protection and switch to
> > mod_devicetable.h
> > iio:adc:ingenic: drop of_match_ptr protection and include
> > mod_devicetable.h
> >
> > drivers/iio/adc/axp20x_adc.c | 10 +++++-----
> > drivers/iio/adc/bcm_iproc_adc.c | 4 ++--
> > drivers/iio/adc/cpcap-adc.c | 22 ++++++----------------
> > drivers/iio/adc/hi8435.c | 6 ++----
> > drivers/iio/adc/ingenic-adc.c | 5 ++---
> > drivers/iio/adc/lpc32xx_adc.c | 5 ++---
> > drivers/iio/adc/ltc2496.c | 4 ++--
> > drivers/iio/adc/ltc2497.c | 4 ++--
> > drivers/iio/adc/max1027.c | 5 ++---
> > drivers/iio/adc/max11100.c | 3 ++-
> > drivers/iio/adc/max1118.c | 7 ++-----
> > drivers/iio/adc/max1363.c | 11 ++++-------
> > drivers/iio/adc/mcp320x.c | 5 ++---
> > drivers/iio/adc/mcp3422.c | 6 ++----
> > drivers/iio/adc/sd_adc_modulator.c | 5 +++--
> > drivers/iio/adc/ti-adc081c.c | 6 ++----
> > drivers/iio/adc/ti-adc0832.c | 7 ++-----
> > drivers/iio/adc/ti-adc084s021.c | 3 ++-
> > drivers/iio/adc/ti-adc108s102.c | 5 ++---
> > drivers/iio/adc/ti-adc128s052.c | 3 ++-
> > drivers/iio/adc/ti-adc161s626.c | 3 ++-
> > drivers/iio/adc/ti-tlc4541.c | 5 ++---
> > 22 files changed, 54 insertions(+), 80 deletions(-)
> >
> > --
> > 2.27.0
> >
>
>
prev parent reply other threads:[~2020-07-04 17:35 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-28 12:36 [PATCH 00/23] iio:adc more of_match_ptr and similar removal Jonathan Cameron
2020-06-28 12:36 ` [PATCH 01/23] iio:adc:lpc32xx: Drop of_match_ptr protection Jonathan Cameron
2020-06-30 7:01 ` Andy Shevchenko
2020-07-04 16:49 ` Jonathan Cameron
2020-06-28 12:36 ` [PATCH 02/23] iio:adc:axp20x: Convert from OF to generic fw / device properties Jonathan Cameron
2020-06-28 17:43 ` Andy Shevchenko
2020-06-28 19:16 ` Jonathan Cameron
2020-06-28 12:36 ` [PATCH 03/23] iio:adc:hi8435: Drop unused of_gpio.h header Jonathan Cameron
2020-07-04 16:52 ` Jonathan Cameron
2020-06-28 12:36 ` [PATCH 04/23] iio:adc:hi8435: Drop of_match_ptr protection Jonathan Cameron
2020-07-04 16:53 ` Jonathan Cameron
2020-06-28 12:36 ` [PATCH 05/23] iio:adc:max1363: Drop of_match_ptr and use generic device_get_match_data Jonathan Cameron
2020-07-04 16:54 ` Jonathan Cameron
2020-06-28 12:36 ` [PATCH 06/23] iio:adc:max1027: drop of_match_ptr and CONFIG_OF protections Jonathan Cameron
2020-07-04 16:56 ` Jonathan Cameron
2020-06-28 12:36 ` [PATCH 07/23] iio:adc:ltc2496: Drop of_match_ptr and use mod_devicetable.h Jonathan Cameron
2020-06-28 15:52 ` Uwe Kleine-König
2020-07-04 16:58 ` Jonathan Cameron
2020-06-28 12:36 ` [PATCH 08/23] iio:adc:cpcap-adc: Drop of_match_ptr protection and use device_get_match_data Jonathan Cameron
2020-06-29 15:21 ` Tony Lindgren
2020-07-04 17:00 ` Jonathan Cameron
2020-06-28 12:36 ` [PATCH 09/23] iio:adc:ltc2497 drop of_match_ptr protection Jonathan Cameron
2020-06-28 15:53 ` Uwe Kleine-König
2020-07-04 17:04 ` Jonathan Cameron
2020-06-28 12:36 ` [PATCH 10/23] iio:adc:max11100: Drop of_match_ptr protection / add mod_devicetable.h include Jonathan Cameron
2020-06-29 7:28 ` Jacopo Mondi
2020-07-04 17:19 ` Jonathan Cameron
2020-06-28 12:36 ` [PATCH 11/23] iio:adc:max1118: Drop CONFIG_OF / of_match_ptr protections Jonathan Cameron
2020-07-04 17:20 ` Jonathan Cameron
2020-06-28 12:36 ` [PATCH 12/23] iio:adc:mcp320x: Drop CONFIG_OF and " Jonathan Cameron
2020-07-04 17:21 ` Jonathan Cameron
2020-06-28 12:36 ` [PATCH 13/23] iio:adc:mcp3422: remove " Jonathan Cameron
2020-07-04 17:22 ` Jonathan Cameron
2020-06-28 12:36 ` [PATCH 14/23] iio:adc:sd_adc_modulator: Drop of_match_ptr and tweak includes Jonathan Cameron
2020-07-04 17:24 ` Jonathan Cameron
2020-06-28 12:36 ` [PATCH 15/23] iio:adc:ti-adc081c: Drop of_match_ptr and change to mod_devicetable.h Jonathan Cameron
2020-06-30 7:12 ` Andy Shevchenko
2020-07-04 15:45 ` Jonathan Cameron
2020-07-04 17:26 ` Jonathan Cameron
2020-07-04 18:31 ` Andy Shevchenko
2020-06-28 12:36 ` [PATCH 16/23] iio:adc:ti-adc0832: drop CONFIG_OF and of_match_ptr protections Jonathan Cameron
2020-07-04 17:29 ` Jonathan Cameron
2020-06-28 12:36 ` [PATCH 17/23] iio:adc:ti-adc084s021: drop of_match_ptr protection Jonathan Cameron
2020-07-04 17:30 ` Jonathan Cameron
2020-06-28 12:36 ` [PATCH 18/23] iio:adc:ti-adc108s102: Drop CONFIG_OF and of_match_ptr protections Jonathan Cameron
2020-06-30 7:20 ` Andy Shevchenko
2020-07-04 15:54 ` Jonathan Cameron
2020-07-04 18:16 ` Andy Shevchenko
2020-06-28 12:36 ` [PATCH 19/23] iio:adc:ti-adc128s052: drop of_match_ptr protection Jonathan Cameron
2020-06-30 7:22 ` Andy Shevchenko
2020-07-04 15:58 ` Jonathan Cameron
2020-07-04 18:20 ` Andy Shevchenko
2020-06-28 12:36 ` [PATCH 20/23] iio:adc:ti-adc161s626: Drop " Jonathan Cameron
2020-06-28 19:51 ` Matt Ranostay
2020-07-04 17:31 ` Jonathan Cameron
2020-06-28 12:36 ` [PATCH 21/23] iio:adc:ti-tlc4541: Drop CONFIG_OF and of_match_ptr protections Jonathan Cameron
2020-06-28 23:43 ` Phil Reid
2020-07-04 17:32 ` Jonathan Cameron
2020-06-28 12:36 ` [PATCH 22/23] iio:adc:bcm_iproc: Drop of_match_ptr protection and switch to mod_devicetable.h Jonathan Cameron
2020-06-30 7:25 ` Andy Shevchenko
2020-07-04 15:59 ` Jonathan Cameron
2020-07-04 18:22 ` Andy Shevchenko
2020-06-28 12:36 ` [PATCH 23/23] iio:adc:ingenic: drop of_match_ptr protection and include mod_devicetable.h Jonathan Cameron
2020-07-04 17:33 ` Jonathan Cameron
2020-06-28 17:53 ` [PATCH 00/23] iio:adc more of_match_ptr and similar removal Andy Shevchenko
2020-06-28 19:32 ` Jonathan Cameron
2020-06-30 7:27 ` Andy Shevchenko
2020-07-04 17:35 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200704183510.119e157a@archlinux \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=alexandru.Ardelean@analog.com \
--cc=andy.shevchenko@gmail.com \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).