From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2637C433E1 for ; Sun, 16 Aug 2020 08:38:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 962302067C for ; Sun, 16 Aug 2020 08:38:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597567103; bh=HZ0nY3DKL4orBHBU7MEJ+GStWLgX85+oJU6g/uPMgUw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=2tPfbfqe59zt8NWqCN27xh2LpfVDXv95pu3n/4TfDGoZ5HuILuUN8efvh58VQv6yN wKq7APCQIN5bOk+mFvxxT5RZz46qrKDKr6tuXgw0MCswViHCZdNRvUFwoRiyHDcLsI J/5GStchQmN1A5h2f/OYFskGRli1DVOImMDZMGKY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726708AbgHPIiX (ORCPT ); Sun, 16 Aug 2020 04:38:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:47720 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726320AbgHPIiW (ORCPT ); Sun, 16 Aug 2020 04:38:22 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BF56B2067C; Sun, 16 Aug 2020 08:38:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597567101; bh=HZ0nY3DKL4orBHBU7MEJ+GStWLgX85+oJU6g/uPMgUw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=cXQZT5+BO2vXQ5dNguRsQOasYjTJi7+l/gU4tHTYagD84wjHyBvA/ENvxBP4+kpfD /Z8bJNd4hUYV8eoytQJ/NR2qm9Y3wFQBkJ6KL6eaNqt50LZbhUPSRq6gcgzK4SIL2D as7zRj3vge5874Yr8zrHs1kjyKIXtCGEFcZiL+IE= Date: Sun, 16 Aug 2020 09:38:17 +0100 From: Jonathan Cameron To: Andy Shevchenko Cc: Crt Mori , linux-iio , Linux Kernel Mailing List Subject: Re: [PATCH v5 5/5] iio:temperature:mlx90632: Some stylefixing leftovers Message-ID: <20200816093817.713a29b3@archlinux> In-Reply-To: References: <20200813075125.4949-1-cmo@melexis.com> <20200813075125.4949-6-cmo@melexis.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Thu, 13 Aug 2020 22:41:51 +0300 Andy Shevchenko wrote: > On Thu, Aug 13, 2020 at 4:12 PM Crt Mori wrote: > > On Thu, 13 Aug 2020 at 13:01, Andy Shevchenko wrote: > > > On Thu, Aug 13, 2020 at 10:53 AM Crt Mori wrote: > > ... > > > > > -#define MLX90632_REF_12 12LL /**< ResCtrlRef value of Ch 1 or Ch 2 */ > > > > -#define MLX90632_REF_3 12LL /**< ResCtrlRef value of Channel 3 */ > > > > -#define MLX90632_MAX_MEAS_NUM 31 /**< Maximum measurements in list */ > > > > -#define MLX90632_SLEEP_DELAY_MS 3000 /**< Autosleep delay */ > > > > > +#define MLX90632_REF_12 12LL /* ResCtrlRef value of Ch 1 or Ch 2 */ > > > > +#define MLX90632_REF_3 12LL /* ResCtrlRef value of Channel 3 */ > > > > +#define MLX90632_MAX_MEAS_NUM 31 /* Maximum measurements in list */ > > > > +#define MLX90632_SLEEP_DELAY_MS 3000 /* Autosleep delay */ > > > > #define MLX90632_EXTENDED_LIMIT 27000 /* Extended mode raw value limit */ > > > > > > This was actually in doxy (perhaps kernel doc also understands this) > > > format of description. > > > Can you double check that the kernel doc is okay / not okay with it? > > > > > > If it is okay, perhaps it's better to convert others to that format > > > rather than dropping it. > > > > > It is indeed from doxygen and looking at other drivers it should not > > be OK. I checked the docs and it does not say in fact. Maybe Jonathan > > knows, but he was already OK with these changes in v1. > > I'm fine with either choice. > I'd prefer to get rid of them as you have done. Jonathan