From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0586C433DF for ; Mon, 12 Oct 2020 14:09:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA91C20776 for ; Mon, 12 Oct 2020 14:09:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729253AbgJLOJz (ORCPT ); Mon, 12 Oct 2020 10:09:55 -0400 Received: from hosting.pavoucek.net ([46.28.107.168]:51312 "EHLO hosting.pavoucek.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731930AbgJLOJz (ORCPT ); Mon, 12 Oct 2020 10:09:55 -0400 X-Greylist: delayed 441 seconds by postgrey-1.27 at vger.kernel.org; Mon, 12 Oct 2020 10:09:53 EDT Received: from tomas.local.tbs-biometrics.cz (176-74-132-138.netdatacomm.cz [176.74.132.138]) (Authenticated sender: tomas@novotny.cz) by hosting.pavoucek.net (Postfix) with ESMTPSA id DB34D104029; Mon, 12 Oct 2020 16:02:30 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 hosting.pavoucek.net DB34D104029 Date: Mon, 12 Oct 2020 16:02:30 +0200 From: Tomas Novotny To: Jonathan Cameron Cc: linux-iio@vger.kernel.org, Rob Herring , Jonathan Cameron Subject: Re: [PATCH 20/29] dt-bindings:iio:dac:microchip,mcp4725 yaml conversion Message-ID: <20201012160230.7a0c5eb8@tomas.local.tbs-biometrics.cz> In-Reply-To: <20201011170749.243680-21-jic23@kernel.org> References: <20201011170749.243680-1-jic23@kernel.org> <20201011170749.243680-21-jic23@kernel.org> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Hi Jonathan, On Sun, 11 Oct 2020 18:07:40 +0100 Jonathan Cameron wrote: > From: Jonathan Cameron > > I'm not sure vdd-supply absolutely has to be provided if vref-supply > is, but as the previous binding docs stated it was required it seems > reasonable to leave it as such. Good catch. Vdd is useless on MCP4726 if Vref is specified. The driver requires Vdd... How to proceed there? Thanks, Tomas > Signed-off-by: Jonathan Cameron > Cc: Tomas Novotny > --- > .../devicetree/bindings/iio/dac/mcp4725.txt | 35 --------- > .../bindings/iio/dac/microchip,mcp4725.yaml | 71 +++++++++++++++++++ > 2 files changed, 71 insertions(+), 35 deletions(-) > > diff --git a/Documentation/devicetree/bindings/iio/dac/mcp4725.txt b/Documentation/devicetree/bindings/iio/dac/mcp4725.txt > deleted file mode 100644 > index 1bc6c093fbfe..000000000000 > --- a/Documentation/devicetree/bindings/iio/dac/mcp4725.txt > +++ /dev/null > @@ -1,35 +0,0 @@ > -Microchip mcp4725 and mcp4726 DAC device driver > - > -Required properties: > - - compatible: Must be "microchip,mcp4725" or "microchip,mcp4726" > - - reg: Should contain the DAC I2C address > - - vdd-supply: Phandle to the Vdd power supply. This supply is used as a > - voltage reference on mcp4725. It is used as a voltage reference on > - mcp4726 if there is no vref-supply specified. > - > -Optional properties (valid only for mcp4726): > - - vref-supply: Optional phandle to the Vref power supply. Vref pin is > - used as a voltage reference when this supply is specified. > - - microchip,vref-buffered: Boolean to enable buffering of the external > - Vref pin. This boolean is not valid without the vref-supply. Quoting > - the datasheet: This is offered in cases where the reference voltage > - does not have the current capability not to drop its voltage when > - connected to the internal resistor ladder circuit. > - > -Examples: > - > - /* simple mcp4725 */ > - mcp4725@60 { > - compatible = "microchip,mcp4725"; > - reg = <0x60>; > - vdd-supply = <&vdac_vdd>; > - }; > - > - /* mcp4726 with the buffered external reference voltage */ > - mcp4726@60 { > - compatible = "microchip,mcp4726"; > - reg = <0x60>; > - vdd-supply = <&vdac_vdd>; > - vref-supply = <&vdac_vref>; > - microchip,vref-buffered; > - }; > diff --git a/Documentation/devicetree/bindings/iio/dac/microchip,mcp4725.yaml b/Documentation/devicetree/bindings/iio/dac/microchip,mcp4725.yaml > new file mode 100644 > index 000000000000..271998610ceb > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/dac/microchip,mcp4725.yaml > @@ -0,0 +1,71 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/dac/microchip,mcp4725.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Microchip mcp4725 and mcp4726 DAC > + > +maintainers: > + - Tomas Novotny > + > +properties: > + compatible: > + enum: > + - microchip,mcp4725 > + - microchip,mcp4726 > + > + reg: > + maxItems: 1 > + > + vdd-supply: > + description: | > + Provides both power and acts as the reference supply on the mcp4725. > + For the mcp4726 it will be used as the reference voltage if vref-supply > + is not provided. > + > + vref-supply: > + description: > + Vref pin is used as a voltage reference when this supply is specified. > + > + microchip,vref-buffered: > + type: boolean > + description: | > + Enable buffering of the external Vref pin. This boolean is not valid > + without the vref-supply. Quoting the datasheet: This is offered in > + cases where the reference voltage does not have the current > + capability not to drop its voltage when connected to the internal > + resistor ladder circuit. > + > +allOf: > + - if: > + not: > + properties: > + compatible: > + contains: > + const: microchip,mcp4726 > + then: > + properties: > + vref-supply: false > + microchip,vref-buffered: false > + > +required: > + - compatible > + - reg > + - vdd-supply > + > +additionalProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + mcp4725@60 { > + compatible = "microchip,mcp4725"; > + reg = <0x60>; > + vdd-supply = <&vdac_vdd>; > + }; > + }; > +...