From: Martin Kepplinger <martin.kepplinger@puri.sm>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: Jonathan Cameron <jic23@kernel.org>,
lorenzo.bianconi@redhat.com, linux-iio@vger.kernel.org
Subject: Re: [BUG] Re: [PATCH] iio: imu: st_lsm6dsx: remove invalid gain value for LSM9DS1
Date: Fri, 30 Aug 2019 14:53:35 +0200 [thread overview]
Message-ID: <531903f2-a4df-87a8-6417-68463261b859@puri.sm> (raw)
In-Reply-To: <20190830072354.GA5910@localhost.localdomain>
On 30.08.19 09:23, Lorenzo Bianconi wrote:
>> On 29.08.19 10:37, Lorenzo Bianconi wrote:
>>>> On 27.08.19 22:08, Jonathan Cameron wrote:
>>>>> On Tue, 27 Aug 2019 10:26:35 +0200
>>>>> Lorenzo Bianconi <lorenzo@kernel.org> wrote:
>>>>>
>>>>>> Get rid of invalid sensitivity value for LSM9DS1 gyro sensor
>>>>>>
>>>>>> Fixes: 687a60feb9c6 ("iio: imu: st_lsm6dsx: add support for accel/gyro unit of lsm9ds1")
>>>>>> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
>>>>> The zero degree scale is certainly odd otherwise, so good to tidy
>>>>> this up.
>>>>>
>>>>> Applied to the togreg branch of iio.git.
>>>>>
>
> [...]
>
>>> struct st_lsm6dsx_fs_table_entry in st_lsm6dsx_settings will always have 4
>>> elements for fs_avl array and since the array is defined as static the
>>> uninitialized elements are set to 0.
>>>
>>> Could you please share the ops you are getting?
>>>
>>
>> How this oops during startup can look like is appended below. I know
>> that exactly this change causes it. Can you test this too please?
>
> I did it but I have no issues
>
>>
>> Given the cleanup nature of this patch, I think it's best to revert it
>> in case of any doubt.
>>
>> thanks,
>>
>> martin
>>
>
> is it the full ops? It seems some parts are missing.
> Are you running some userspace aps reading in_anglvel_scale_available or reading/writing in in_anglvel_scale?
> Could you please double check if the following patch helps? (just compiled)
>
it does not, and you're right, the problem should be somewhere else.
I've yet to debug it further.
thanks,
martin
next prev parent reply other threads:[~2019-08-30 12:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 8:26 [PATCH] iio: imu: st_lsm6dsx: remove invalid gain value for LSM9DS1 Lorenzo Bianconi
2019-08-27 20:08 ` Jonathan Cameron
2019-08-29 5:27 ` [BUG] " Martin Kepplinger
2019-08-29 5:50 ` [PATCH] Revert "iio: imu: st_lsm6dsx: remove invalid gain value for LSM9DS1" Martin Kepplinger
2019-08-29 8:37 ` [BUG] Re: [PATCH] iio: imu: st_lsm6dsx: remove invalid gain value for LSM9DS1 Lorenzo Bianconi
2019-08-30 6:01 ` Martin Kepplinger
2019-08-30 7:23 ` Lorenzo Bianconi
2019-08-30 12:53 ` Martin Kepplinger [this message]
2019-08-31 9:32 ` Lorenzo Bianconi
2019-09-01 14:50 ` Jonathan Cameron
2019-09-03 5:22 ` Martin Kepplinger
2019-09-03 12:37 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531903f2-a4df-87a8-6417-68463261b859@puri.sm \
--to=martin.kepplinger@puri.sm \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).