From: Philippe Schenker <philippe.schenker@toradex.com>
To: "jic23@kernel.org" <jic23@kernel.org>,
"David.Laight@ACULAB.COM" <David.Laight@ACULAB.COM>
Cc: "stefan@agner.ch" <stefan@agner.ch>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
"alexandre.torgue@st.com" <alexandre.torgue@st.com>,
Max Krummenacher <max.krummenacher@toradex.com>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"lee.jones@linaro.org" <lee.jones@linaro.org>,
"pmeerw@pmeerw.net" <pmeerw@pmeerw.net>,
"knaack.h@gmx.de" <knaack.h@gmx.de>,
"mcoquelin.stm32@gmail.com" <mcoquelin.stm32@gmail.com>,
"lars@metafoo.de" <lars@metafoo.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: [PATCH 2/3] iio: stmpe-adc: Make wait_completion non interruptible
Date: Tue, 7 May 2019 14:31:49 +0000 [thread overview]
Message-ID: <69a00774deb5d5c8f5611855fa354cccbe92a6aa.camel@toradex.com> (raw)
In-Reply-To: <4df31129d19c4128a4bbc5e0575886af@AcuMS.aculab.com>
On Tue, 2019-05-07 at 08:23 +0000, David Laight wrote:
> From: Jonathan Cameron
> > Sent: 05 May 2019 16:44
> > On Fri, 3 May 2019 15:58:38 +0000
> > Philippe Schenker <philippe.schenker@toradex.com> wrote:
> >
> > > On Fri, 2019-05-03 at 14:39 +0000, David Laight wrote:
> > > > From: Philippe Schenker
> > > > > Sent: 03 May 2019 14:57
> > > > > In some cases, the wait_completion got interrupted. This caused the
> > > > > error-handling to mutex_unlock the function. The before turned on
> > > > > interrupt then got called anyway. In the ISR then completion()
> > > > > was called causing problems.
> > > > >
> > > > > Making this wait_completion non interruptible solves the problem.
> > > >
> > > > Won't the same thing happen if the interrupt occurs just after
> > > > the timeout?
> > > >
> > > > David
> > > >
> > > >
> > > > -
> > > > Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes,
> > > > MK1 1PT,
> > > > UK
> > > > Registration No: 1397386 (Wales)
> > > >
> > >
> > > You're of course right... Thanks for pointing this out. I will send a v2
> > > with a
> > > better solution then.
> > >
> >
> > Isn't the timeout long enough that it should only happen if the hardware has
> > a fault? If that's the case, I wouldn't worry too much about possibility of
> > an interrupt causing confusion as long as it isn't catastrophic.
>
> The 'confusion' is likely to be 'catastrophic' unless the code is written
> to handle it properly.
>
> Cancelling callbacks is hard to get right and often not done properly.
> Timing out an interrupt is much the same problem.
>
> David
I sorted it out now, there where also some more bugs I found and corrected.
@Jonathan: I will send a completely new series of patches that will include
patch 3/3 from this series but not the one you already applied. This due to
increased patch number and different order...
>
> -
> Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT,
> UK
> Registration No: 1397386 (Wales)
>
next prev parent reply other threads:[~2019-05-07 14:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-03 13:57 [PATCH 1/3] iio: stmpe-adc: Remove unnecessary assignment Philippe Schenker
2019-05-03 13:57 ` [PATCH 2/3] iio: stmpe-adc: Make wait_completion non interruptible Philippe Schenker
2019-05-03 14:39 ` David Laight
2019-05-03 15:58 ` Philippe Schenker
[not found] ` <20190505164409.7976f43e@archlinux>
[not found] ` <4df31129d19c4128a4bbc5e0575886af@AcuMS.aculab.com>
2019-05-07 14:31 ` Philippe Schenker [this message]
2019-05-03 13:57 ` [PATCH 3/3] iio: stmpe-adc: Enable all stmpe-adc interrupts just once Philippe Schenker
2019-05-05 15:45 ` Jonathan Cameron
2019-05-07 14:32 ` Philippe Schenker
2019-05-05 15:39 ` [PATCH 1/3] iio: stmpe-adc: Remove unnecessary assignment Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69a00774deb5d5c8f5611855fa354cccbe92a6aa.camel@toradex.com \
--to=philippe.schenker@toradex.com \
--cc=David.Laight@ACULAB.COM \
--cc=alexandre.torgue@st.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=marcel.ziswiler@toradex.com \
--cc=max.krummenacher@toradex.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=pmeerw@pmeerw.net \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).