Re: Question about ADIS162XX low voltage status bit

From: Alexandru Ardelean <ardeleanalex@gmail.com>
To: Pedro Sousa <pedroteosousa@gmail.com>
Cc: linux-iio@vger.kernel.org,
	Alexandru Ardelean <alexandru.ardelean@analog.com>
Subject: Re: Question about ADIS162XX low voltage status bit
Date: Mon, 20 May 2019 14:57:07 +0300	[thread overview]
Message-ID: <CA+U=DspSs3xnYwyT_JUgJiYLzWW=d+qOAwg_rryRq7upew_1JA@mail.gmail.com> (raw)
In-Reply-To: <CAMyZ8d4ya5VpgnQBS-8isgQP5RcoDbxyRGnxYWhjtL1b2RagwQ@mail.gmail.com>

On Sat, May 18, 2019 at 11:51 PM Pedro Sousa <pedroteosousa@gmail.com> wrote:
>
> Hi everyone,
>
> I saw that all iio drivers ADIS162XX have a comment on the low voltage
> status bit specifying 3.15V as a safe lower bound, but this value does
> not match the ones in the datasheet, which are all lower. What is the
> reason for this discrepancy?

Good find.
You are correct. The values should be 2.975V in the driver.
This is a bit hard-to-tell (why it happened to be 3.15 in the driver).

Sometimes, drivers are written before the part is released, and the
specs sometimes change from Rev A to Rev E.
Or the docs get corrected.
Or, sometimes copies a base driver from somewhere else, and forgets to
update things; no idea if that was the case here.

In any case, feel free to send a patch to fix the driver.
If not, we can send to fix them.

Thanks
Alex