linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: AceLan Kao <acelan.kao@canonical.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: William Sung <william.sung@advantech.com.tw>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Michael Hennerich <Michael.Hennerich@analog.com>,
	Jonathan Cameron <jic23@kernel.org>,
	Hartmut Knaack <knaack.h@gmx.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	linux-iio <linux-iio@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Campion Kang <Campion.Kang@advantech.com.tw>
Subject: Re: [PATCH] iio: dac: ad5593r: Dynamically set AD5593R channel modes
Date: Mon, 31 Aug 2020 19:28:37 +0800	[thread overview]
Message-ID: <CAFv23QmDwcrdxEndH=mKMAomzt9kxG_f1Z6=Fd8iuuvCoY92SA@mail.gmail.com> (raw)
In-Reply-To: <CAHp75VeZLPR02xB2XRzec5mSBvq93XYZg56OOODxpFTPva6cXw@mail.gmail.com>

Hi Jonathan and Andy,

This patch is mainly for Advantech's UNO-420[1] which is a x86-based platform.
This platform is more like a development platform for customers to
customize their products,
so, specify the channel modes in ACPI table is not generic enough,
that's why William submit this patch.

Are there other ways to specify or pass values to the module without
using module parameters?
It's good if we can leverage sysfs, but I don't know if there is one
for this scenario.

1. https://www.advantech.com/products/9a0cc561-8fc2-4e22-969c-9df90a3952b5/uno-420/mod_2d6a546b-39e3-4bc4-bbf4-ac89e6b7667c

Andy Shevchenko <andy.shevchenko@gmail.com> 於 2020年8月31日 週一 上午1:07寫道:
>
> On Mon, Aug 24, 2020 at 8:54 AM William Sung
> <william.sung@advantech.com.tw> wrote:
> >
> > To use ad5593r more flexibly, we use the module parameter to setting the
> > channel modes dynamically whenever the module probe up.
>
> > Users can pass
> > the channel modes to the module parameter for allocating the
> > functionality of channels as desired.
>
> NAK. We have a sysfs interface.
>
> > For example:
> > * Use in the kernel command line:
> > Users can add the module parameter in the kernel command line such as
> >
> >     "ad5593r.ch_mode_cmdline=88001122"
> >
> > "88001122" means the channel mode setting for each channel. The most
> > left side indicates the mode of channel 7, and the most right side
> > indicates the mode of channel 0.
> >
> > * Use when manually probe the module:
> > Similar to the kernel command line usage, users can enter
> >
> >     "modprobe ad5593r ch_mode_probe=88001122"
> >
> > to start the ad5593r module with the desired channel mode setting.
>
> Again NAK, this basically should come from Device Tree or ACPI.
>
> --
> With Best Regards,
> Andy Shevchenko

  reply	other threads:[~2020-08-31 11:29 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-24  5:43 [PATCH] iio: dac: ad5593r: Dynamically set AD5593R channel modes William Sung
2020-08-25  4:15 ` AceLan Kao
2020-08-30 17:07 ` Andy Shevchenko
2020-08-31 11:28   ` AceLan Kao [this message]
2020-08-31 12:45     ` Andy Shevchenko
2020-08-31 12:47       ` Andy Shevchenko
2020-09-03  7:37         ` AceLan Kao
2020-09-03 10:42           ` Andy Shevchenko
2020-09-03 10:54             ` Andy Shevchenko
2020-09-04  2:25               ` AceLan Kao
2020-09-04  7:40                 ` Andy Shevchenko
     [not found]             ` <b1581dc61d584cffa2588f72b888ffa0@taipei09.ADVANTECH.CORP>
2020-09-04  7:48               ` Andy Shevchenko
     [not found]                 ` <705b481901d64d30830689f0aa541cb9@taipei09.ADVANTECH.CORP>
2020-09-04 11:38                   ` Andy Shevchenko
2020-09-04 11:43                     ` Andy Shevchenko
2020-09-02  8:09       ` Hennerich, Michael
2020-09-02  8:52         ` Andy Shevchenko
2020-09-02  9:11           ` Hennerich, Michael
2020-09-02  9:28             ` Andy Shevchenko
2020-09-02 13:23               ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFv23QmDwcrdxEndH=mKMAomzt9kxG_f1Z6=Fd8iuuvCoY92SA@mail.gmail.com' \
    --to=acelan.kao@canonical.com \
    --cc=Campion.Kang@advantech.com.tw \
    --cc=Michael.Hennerich@analog.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=william.sung@advantech.com.tw \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).