From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Christian Eggers <ceggers@arri.de>
Cc: Rob Herring <robh+dt@kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio <linux-iio@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] iio: light: as73211: New driver
Date: Fri, 31 Jul 2020 10:10:50 +0300 [thread overview]
Message-ID: <CAHp75VcO=Gx-G53otdD4QMuzPWBetyFOE1P2uyg8zz7w8fnQwA@mail.gmail.com> (raw)
In-Reply-To: <6453117.yIeBT9JUrU@n95hx1g2>
On Fri, Jul 31, 2020 at 9:55 AM Christian Eggers <ceggers@arri.de> wrote:
> On Thursday, 30 July 2020, 13:31:31 CEST, Andy Shevchenko wrote:
> > On Thu, Jul 30, 2020 at 1:52 PM Christian Eggers <ceggers@arri.de> wrote:
...
> > > + * @buffer: Buffer for triggered measurements.
> > Actually Jonathan is correct -- the above has kernel doc issues.
> That's correct (the description for @buffer has to be removed). I didn't figure
> out how to automatically check for this. When building with V=1 C=1, I only get
> the message "as73211.c:76: info: Scanning doc for struct as73211_data".
W=1 (not V=1) runs kernel doc validation script.
...
> > > +static unsigned int as73211_gain(struct as73211_data *data)
> > > +{
> > >
> > > + return BIT(0xb - FIELD_GET(AS73211_CREG1_GAIN_MASK, data->creg1));
> >
> > Magic!
> Similarly it's difficult to find an eligible alias for the 0xb as the
> whole expression is constructed from viewing tables on the data sheet. I added
> some comment.
For this and the rest, descriptive comment is okay.
...
> > > + if (val < 0 || (freq_kHz * 1000) != val || val2)
> >
> > Ditto.
> I switched to existing defined where possible. But I wouldn't like to introduce
> this for every possible physical unit. Please check again in v4.
I'll do check.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-07-31 7:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 10:49 [PATCH v3 0/2] iio: light: Support AMS AS73211 digital XYZ sensor Christian Eggers
2020-07-30 10:49 ` [PATCH v3 1/2] dt-bindings: iio: light: add AMS AS73211 support Christian Eggers
2020-07-30 10:49 ` [PATCH v3 2/2] iio: light: as73211: New driver Christian Eggers
2020-07-30 11:31 ` Andy Shevchenko
2020-07-31 6:54 ` Christian Eggers
2020-07-31 7:10 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VcO=Gx-G53otdD4QMuzPWBetyFOE1P2uyg8zz7w8fnQwA@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=ceggers@arri.de \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).