From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Crt Mori <cmo@melexis.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 3/5] iio:temperature:mlx90632: Convert polling while loop to do-while
Date: Fri, 14 Aug 2020 15:11:01 +0300 [thread overview]
Message-ID: <CAHp75Vd+CZQCtDX8LUbQef7cQyG7brJT6S5rZeSZHTB1ZArSgQ@mail.gmail.com> (raw)
In-Reply-To: <CAKv63utpidP12iQXWU59=F+cVCq6oShSAitmKhoC4W4aaPtnRA@mail.gmail.com>
On Fri, Aug 14, 2020 at 12:42 PM Crt Mori <cmo@melexis.com> wrote:
> On Fri, 14 Aug 2020 at 11:32, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> > On Fri, Aug 14, 2020 at 10:33 AM Crt Mori <cmo@melexis.com> wrote:
> > > On Thu, 13 Aug 2020 at 21:41, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> > > > On Thu, Aug 13, 2020 at 4:04 PM Crt Mori <cmo@melexis.com> wrote:
> > > > > On Thu, 13 Aug 2020 at 13:24, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
...
> > > > > usleep_range(10000, 11000);
Above for 4 attempts is up to 44000us.
With iopoll.h case we may set
delay_us = 18000 (the result range will be 4500, 18000)
timeout_us = 72000 (this will give up to 16 attempts to read)
> I tested on Beaglebone with the 100 * 10000 as timeout_us and I always
> got the -ETIMEDOUT error. I also tested in the other case where
> delay_us is 250000 and then timeout_us would be 4*250000 and I have
> also received -ETIMEDOUT as a response.
I don't see how delay_us should be bigger than 20ms (20000).
> I can prepare a patch with the iopoll.h API and maybe you will spot
> the mistake, as after rechecking timeout_us is indeed 64bit and is
> only used in the time comparison operations and not with timers.
Perhaps above will clarify.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-08-14 12:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 7:51 [PATCH v5 0/5] iio: temperature: mlx90632: Add extended calibration calculations Crt Mori
2020-08-13 7:51 ` [PATCH v5 1/5] iio:temperature:mlx90632: Reduce number of equal calulcations Crt Mori
2020-08-13 7:51 ` [PATCH v5 2/5] iio:temperature:mlx90632: Add kerneldoc to the internal struct Crt Mori
2020-08-13 10:54 ` Andy Shevchenko
2020-08-13 7:51 ` [PATCH v5 3/5] iio:temperature:mlx90632: Convert polling while loop to do-while Crt Mori
2020-08-13 11:03 ` Andy Shevchenko
2020-08-13 11:13 ` Crt Mori
2020-08-13 11:24 ` Andy Shevchenko
2020-08-13 13:03 ` Crt Mori
2020-08-13 19:40 ` Andy Shevchenko
2020-08-14 7:32 ` Crt Mori
2020-08-14 9:31 ` Andy Shevchenko
2020-08-14 9:42 ` Crt Mori
2020-08-14 12:11 ` Andy Shevchenko [this message]
2020-08-13 7:51 ` [PATCH v5 4/5] iio:temperature:mlx90632: Adding extended calibration option Crt Mori
2020-08-13 11:06 ` Andy Shevchenko
2020-08-13 7:51 ` [PATCH v5 5/5] iio:temperature:mlx90632: Some stylefixing leftovers Crt Mori
2020-08-13 11:01 ` Andy Shevchenko
2020-08-13 13:11 ` Crt Mori
2020-08-13 19:41 ` Andy Shevchenko
2020-08-16 8:38 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vd+CZQCtDX8LUbQef7cQyG7brJT6S5rZeSZHTB1ZArSgQ@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=cmo@melexis.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).