Re: [PATCH 28/38] iio:chemical:vz89x: Introduce local struct device pointer.

From: Matt Ranostay <matt.ranostay@konsulko.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@vger.kernel.org>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH 28/38] iio:chemical:vz89x: Introduce local struct device pointer.
Date: Tue, 15 Sep 2020 12:02:56 -0700	[thread overview]
Message-ID: <CAJCx=gnEVWM6ft45rOWU6BSP60dVq_3tzpZC41X8uGr3muWGsA@mail.gmail.com> (raw)
In-Reply-To: <20200910173242.621168-29-jic23@kernel.org>

On Thu, Sep 10, 2020 at 10:35 AM Jonathan Cameron <jic23@kernel.org> wrote:
>
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Avoids lots of repition of &client->dev and will make the next
> patch tidier.

Typo of repetition.

>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Matt Ranostay <matt.ranostay@konsulko.com>

Acked-by: Matt Ranostay <matt.ranostay@konsulko.com>

> ---
>  drivers/iio/chemical/vz89x.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iio/chemical/vz89x.c b/drivers/iio/chemical/vz89x.c
> index 5586eb8e12cd..3cd469578590 100644
> --- a/drivers/iio/chemical/vz89x.c
> +++ b/drivers/iio/chemical/vz89x.c
> @@ -352,12 +352,13 @@ MODULE_DEVICE_TABLE(of, vz89x_dt_ids);
>  static int vz89x_probe(struct i2c_client *client,
>                        const struct i2c_device_id *id)
>  {
> +       struct device *dev = &client->dev;
>         struct iio_dev *indio_dev;
>         struct vz89x_data *data;
>         const struct of_device_id *of_id;
>         int chip_id;
>
> -       indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*data));
> +       indio_dev = devm_iio_device_alloc(dev, sizeof(*data));
>         if (!indio_dev)
>                 return -ENOMEM;
>         data = iio_priv(indio_dev);
> @@ -370,7 +371,7 @@ static int vz89x_probe(struct i2c_client *client,
>         else
>                 return -EOPNOTSUPP;
>
> -       of_id = of_match_device(vz89x_dt_ids, &client->dev);
> +       of_id = of_match_device(vz89x_dt_ids, dev);
>         if (!of_id)
>                 chip_id = id->driver_data;
>         else
> @@ -383,13 +384,13 @@ static int vz89x_probe(struct i2c_client *client,
>         mutex_init(&data->lock);
>
>         indio_dev->info = &vz89x_info;
> -       indio_dev->name = dev_name(&client->dev);
> +       indio_dev->name = dev_name(dev);
>         indio_dev->modes = INDIO_DIRECT_MODE;
>
>         indio_dev->channels = data->chip->channels;
>         indio_dev->num_channels = data->chip->num_channels;
>
> -       return devm_iio_device_register(&client->dev, indio_dev);
> +       return devm_iio_device_register(dev, indio_dev);
>  }
>
>  static const struct i2c_device_id vz89x_id[] = {
> --
> 2.28.0
>