From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Sean Rhodes <sean@starlabs.systems>,
"Rafael J . Wysocki" <rafael@kernel.org>,
linux-iio@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH v2 0/4] iio: accel: Share ACPI ROTM parsing between drivers and add it to mxc4005
Date: Mon, 22 Apr 2024 18:06:24 +0200 [thread overview]
Message-ID: <CAJZ5v0iHSiT=P4gawrvWE8y143Q-02Ps8WQKM9k9Z+TctL3kXw@mail.gmail.com> (raw)
In-Reply-To: <20240422100218.7693-1-hdegoede@redhat.com>
Hi Hans,
On Mon, Apr 22, 2024 at 12:02 PM Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi All,
>
> Here is v2 of the patch series to refactor the ACPI ROTM orientation matrix
> handling in kxcjk-1013 + bmc150-accel to share the code instead of having
> 2 copies and then also use the shared implementation in the mxc4005 driver
> since some MXC6655 ACPI firmware nodes also include this.
>
> Changes in v2:
> - Add comment about the Microsoft specification for the "ROTM" ACPI method
>
> Regards,
>
> Hans
>
>
> Hans de Goede (4):
> iio: accel: kxcjk-1013: Simplify ACPI ROTM mount matrix retreival
> iio: accel: kxcjk-1013: Move ACPI ROTM parsing to new acpi-helpers.h
> iio: bmc150-accel-core: Use acpi_read_mount_matrix() helper
> iio: accel: mxc4005: Read orientation matrix from ACPI ROTM method
>
> drivers/iio/accel/acpi-helpers.h | 83 +++++++++++++++++++++++++++
> drivers/iio/accel/bmc150-accel-core.c | 45 +--------------
> drivers/iio/accel/kxcjk-1013.c | 82 +-------------------------
> drivers/iio/accel/mxc4005.c | 24 ++++++++
> 4 files changed, 113 insertions(+), 121 deletions(-)
> create mode 100644 drivers/iio/accel/acpi-helpers.h
>
> --
The series LGTM, so please feel free to add
Acked-by: Rafael J. Wysocki <rafael@kernel.org>
to it.
Thanks!
prev parent reply other threads:[~2024-04-22 16:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 10:02 [PATCH v2 0/4] iio: accel: Share ACPI ROTM parsing between drivers and add it to mxc4005 Hans de Goede
2024-04-22 10:02 ` [PATCH v2 1/4] iio: accel: kxcjk-1013: Simplify ACPI ROTM mount matrix retreival Hans de Goede
2024-04-22 10:02 ` [PATCH v2 2/4] iio: accel: kxcjk-1013: Move ACPI ROTM parsing to new acpi-helpers.h Hans de Goede
2024-04-22 10:02 ` [PATCH v2 3/4] iio: bmc150-accel-core: Use acpi_read_mount_matrix() helper Hans de Goede
2024-04-22 10:02 ` [PATCH v2 4/4] iio: accel: mxc4005: Read orientation matrix from ACPI ROTM method Hans de Goede
2024-04-22 16:06 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZ5v0iHSiT=P4gawrvWE8y143Q-02Ps8WQKM9k9Z+TctL3kXw@mail.gmail.com' \
--to=rafael@kernel.org \
--cc=hdegoede@redhat.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=sean@starlabs.systems \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).