From: Rob Herring <robh+dt@kernel.org>
To: Mircea Caprioru <mircea.caprioru@analog.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Stefan Popa <stefan.popa@analog.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@vger.kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH V2 4/4] dt-bindings: iio: adc: ad7192: Add binding documentation for AD7192
Date: Tue, 13 Aug 2019 15:34:42 -0600 [thread overview]
Message-ID: <CAL_JsqJo-LMmG8B6mitr38TdSj7ejrbGvcsy6TQAtvi6MoemOg@mail.gmail.com> (raw)
In-Reply-To: <20190813075544.9122-4-mircea.caprioru@analog.com>
On Tue, Aug 13, 2019 at 1:56 AM Mircea Caprioru
<mircea.caprioru@analog.com> wrote:
>
> This patch add device tree binding documentation for AD7192 adc in YAML
> format.
>
> Signed-off-by: Mircea Caprioru <mircea.caprioru@analog.com>
> ---
> Changelog V2:
> - remove description from spi and interrupt properties
> - changed the name of the device from ad7192 to adc in the example
>
> .../bindings/iio/adc/adi,ad7192.yaml | 121 ++++++++++++++++++
> 1 file changed, 121 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml
> new file mode 100644
> index 000000000000..2d83724cb4d6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml
> @@ -0,0 +1,121 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +# Copyright 2019 Analog Devices Inc.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/bindings/iio/adc/adi,ad7192.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices AD7192 ADC device driver
> +
> +maintainers:
> + - Michael Hennerich <michael.hennerich@analog.com>
> +
> +description: |
> + Bindings for the Analog Devices AD7192 ADC device. Datasheet can be
> + found here:
> + https://www.analog.com/media/en/technical-documentation/data-sheets/AD7192.pdf
> +
> +properties:
> + compatible:
> + enum:
> + - adi,ad7190
> + - adi,ad7192
> + - adi,ad7193
> + - adi,ad7195
> +
> + reg:
> + maxItems: 1
> +
> + spi-cpol: true
> +
> + spi-cpha: true
> +
> + clocks:
> + maxItems: 1
> + description: phandle to the master clock (mclk)
> +
> + clock-names:
> + items:
> + - const: mclk
> +
> + interrupts:
> + maxItems: 1
> +
> + dvdd-supply:
> + description: DVdd voltage supply
> + items:
> + - const: dvdd
> +
> + avdd-supply:
> + description: AVdd voltage supply
> + items:
> + - const: avdd
> +
> + adi,rejection-60-Hz-enable:
> + description: |
> + This bit enables a notch at 60 Hz when the first notch of the sinc
> + filter is at 50 Hz. When REJ60 is set, a filter notch is placed at
> + 60 Hz when the sinc filter first notch is at 50 Hz. This allows
> + simultaneous 50 Hz/ 60 Hz rejection.
> + type: boolean
> +
> + adi,refin2-pins-enable:
> + description: |
> + External reference applied between the P1/REFIN2(+) and P0/REFIN2(−) pins.
> + type: boolean
> +
> + adi,buffer-enable:
> + description: |
> + Enables the buffer on the analog inputs. If cleared, the analog inputs
> + are unbuffered, lowering the power consumption of the device. If this
> + bit is set, the analog inputs are buffered, allowing the user to place
> + source impedances on the front end without contributing gain errors to
> + the system.
> + type: boolean
> +
> + adi,burnout-currents-enable:
> + description: |
> + When this bit is set to 1, the 500 nA current sources in the signal
> + path are enabled. When BURN = 0, the burnout currents are disabled.
> + The burnout currents can be enabled only when the buffer is active
> + and when chop is disabled.
> + type: boolean
> +
> + bipolar:
> + description: see Documentation/devicetree/bindings/iio/adc/adc.txt
> + type: boolean
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> + - interrupts
> + - dvdd-supply
> + - avdd-supply
> + - spi-cpol
> + - spi-cpha
> +
> +examples:
> + - |
> + spi0 {
> + adc@0 {
> + compatible = "adi,ad7192";
> + reg = <0>;
> + spi-max-frequency = <1000000>;
> + spi-cpol;
> + spi-cpha;
> + clocks = <&ad7192_mclk>;
> + clock-names = "mclk";
> + #interrupt-cells = <2>;
> + interrupts = <25 0x2>;
> + interrupt-parent = <&gpio>;
> + dvdd-supply = <&dvdd>;
> + avdd-supply = <&avdd>;
> +
> + adi,refin2-pins-enable;
> + adi,rejection-60-Hz-enable;
> + adi,buffer-enable;
> + adi,burnout-currents-enable;
> + };
> + }
You didn't build this with 'make dt_binding_check'. Please do so and
fix the error here.
Rob
prev parent reply other threads:[~2019-08-13 21:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 7:55 [PATCH V2 1/4] staging: iio: adc: ad7192: Add low_pass_3db_filter_frequency Mircea Caprioru
2019-08-13 7:55 ` [PATCH V2 2/4] iio: adc: ad_sigma_delta: Export ad_sd_calibrate Mircea Caprioru
2019-08-13 7:55 ` [PATCH V2 3/4] staging: iio: adc: ad7192: Add system calibration support Mircea Caprioru
2019-08-13 7:55 ` [PATCH V2 4/4] dt-bindings: iio: adc: ad7192: Add binding documentation for AD7192 Mircea Caprioru
2019-08-13 21:34 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqJo-LMmG8B6mitr38TdSj7ejrbGvcsy6TQAtvi6MoemOg@mail.gmail.com \
--to=robh+dt@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mircea.caprioru@analog.com \
--cc=stefan.popa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).