From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF247C433DF for ; Mon, 17 Aug 2020 14:18:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BF56F22B49 for ; Mon, 17 Aug 2020 14:18:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597673887; bh=4qw0p6oQML7YmbV0GkEi7fZNxZopyXODUoJ+09bMFJc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=t+JlhPn1bGS8k32IkJcfI9gsic/v+S5mehVbxgsMimXEROajjg+1WhOJeSYHNY88d AyIAKLYQryY0Wy6RYNL6dP1uRqljfqnasTwDG4BHCFswtHS+IoAKewSLBTIC1f5TzU dvsd0T3y5cDBd8lCWBLI9GcKUE/hG5j6oWIM8Vzs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728824AbgHQOSH (ORCPT ); Mon, 17 Aug 2020 10:18:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:56816 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728669AbgHQOSF (ORCPT ); Mon, 17 Aug 2020 10:18:05 -0400 Received: from mail-ot1-f46.google.com (mail-ot1-f46.google.com [209.85.210.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3A7C220674; Mon, 17 Aug 2020 14:18:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597673885; bh=4qw0p6oQML7YmbV0GkEi7fZNxZopyXODUoJ+09bMFJc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=0tSkDjBnDUvb4dObmXkHRkv4wNbP/FENorV2+midoKh8vfEg8imCLoCmL77KCHNmG +WCUr3G0xyhgq1TCRW8eZg1juTucC98Aoht8+yn3i0TPi86EJgz8fjYnobov+scOnF vGY2jjWmmHg1ALuQDM3oYZfoWFwaFtf2DoZzJXIg= Received: by mail-ot1-f46.google.com with SMTP id v21so13492334otj.9; Mon, 17 Aug 2020 07:18:05 -0700 (PDT) X-Gm-Message-State: AOAM530WftMwROK8PvBsxPCrqb//OGChZQo0Mu8nfAcdXSNaX9z/DR+R /sGSSLbXVnpaKUX+5NfFScp8sNAIv37TwfGF+w== X-Google-Smtp-Source: ABdhPJzVNykJU1/t96e6tbnhJqBq8O2bJ4YGJ60Yrkf++i1GLKvXKQh05ZLBs34g02cjue7lJi6nmCuaHF1eUid5uGI= X-Received: by 2002:a9d:7f84:: with SMTP id t4mr11508847otp.192.1597673884538; Mon, 17 Aug 2020 07:18:04 -0700 (PDT) MIME-Version: 1.0 References: <20200809111753.156236-1-jic23@kernel.org> <20200809111753.156236-9-jic23@kernel.org> In-Reply-To: <20200809111753.156236-9-jic23@kernel.org> From: Rob Herring Date: Mon, 17 Aug 2020 08:17:52 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 08/13] dt-bindings: iio: adc: ti,adc12138 yaml conversion. To: Jonathan Cameron Cc: "open list:IIO SUBSYSTEM AND DRIVERS" , devicetree@vger.kernel.org, Jonathan Cameron , Akinobu Mita Content-Type: text/plain; charset="UTF-8" Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Sun, Aug 9, 2020 at 5:20 AM Jonathan Cameron wrote: > > From: Jonathan Cameron > > Simple binding conversion. Only addition was #io-channel-cells to > allow for potential consumers of the channels on this device. > > Signed-off-by: Jonathan Cameron > Cc: Akinobu Mita > --- > .../bindings/iio/adc/ti,adc12138.yaml | 85 +++++++++++++++++++ > .../bindings/iio/adc/ti-adc12138.txt | 37 -------- > 2 files changed, 85 insertions(+), 37 deletions(-) > > diff --git a/Documentation/devicetree/bindings/iio/adc/ti,adc12138.yaml b/Documentation/devicetree/bindings/iio/adc/ti,adc12138.yaml > new file mode 100644 > index 000000000000..3e8c43aa8ef3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/ti,adc12138.yaml > @@ -0,0 +1,85 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/adc/ti,adc12138.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Texas Instruments ADC12138 and similar self-calibrating ADCs > + > +maintainers: > + - Akinobu Mita > + > +description: | > + 13 bit ADCs with 1, 2 or 8 inputs and self calibrating circuitry to > + correct for linearity, zero and full scale errors. > + > +properties: > + compatible: > + enum: > + - ti,adc12130 > + - ti,adc12132 > + - ti,adc12138 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + description: End of Conversion (EOC) interrupt > + > + clocks: > + maxItems: 1 > + description: Conversion clock input. > + > + spi-max-frequency: true > + > + vref-p-supply: > + description: The regulator supply for positive analog voltage reference > + > + vref-n-suppy: typo > + description: | > + The regulator supply for negative analog voltage reference > + (Note that this must not go below GND or exceed vref-p) > + If not specified, this is assumed to be analog ground. > + > + ti,acquisition-time: > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [ 6, 10, 18, 34] Inconsistent spacing for brackets. 0 or 1 space is fine. > + description: | > + The number of conversion clock periods for the S/H's acquisition time. > + For high source impedances, this value can be increased to 18 or 34. > + For less ADC accuracy and/or slower CCLK frequencies this value may be > + decreased to 6. See section 6.0 INPUT SOURCE RESISTANCE in the > + datasheet for details. > + > + "#io-channel-cells": > + const: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - vref-p-supply > + > +additionalProperties: false > + > +examples: > + - | > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + > + adc@0 { > + compatible = "ti,adc12138"; > + reg = <0>; > + interrupts = <28 IRQ_TYPE_EDGE_RISING>; > + interrupt-parent = <&gpio1>; > + clocks = <&cclk>; > + vref-p-supply = <&ldo4_reg>; > + spi-max-frequency = <5000000>; > + ti,acquisition-time = <6>; > + #io-channel-cells = <1>; > + }; > + }; > +... > diff --git a/Documentation/devicetree/bindings/iio/adc/ti-adc12138.txt b/Documentation/devicetree/bindings/iio/adc/ti-adc12138.txt > deleted file mode 100644 > index 049a1d36f013..000000000000 > --- a/Documentation/devicetree/bindings/iio/adc/ti-adc12138.txt > +++ /dev/null > @@ -1,37 +0,0 @@ > -* Texas Instruments' ADC12130/ADC12132/ADC12138 > - > -Required properties: > - - compatible: Should be one of > - * "ti,adc12130" > - * "ti,adc12132" > - * "ti,adc12138" > - - reg: SPI chip select number for the device > - - interrupts: Should contain interrupt for EOC (end of conversion) > - - clocks: phandle to conversion clock input > - - spi-max-frequency: Definision as per > - Documentation/devicetree/bindings/spi/spi-bus.txt > - - vref-p-supply: The regulator supply for positive analog voltage reference > - > -Optional properties: > - - vref-n-supply: The regulator supply for negative analog voltage reference > - (Note that this must not go below GND or exceed vref-p) > - If not specified, this is assumed to be analog ground. > - - ti,acquisition-time: The number of conversion clock periods for the S/H's > - acquisition time. Should be one of 6, 10, 18, 34. If not specified, > - default value of 10 is used. > - For high source impedances, this value can be increased to 18 or 34. > - For less ADC accuracy and/or slower CCLK frequencies this value may be > - decreased to 6. See section 6.0 INPUT SOURCE RESISTANCE in the > - datasheet for details. > - > -Example: > -adc@0 { > - compatible = "ti,adc12138"; > - reg = <0>; > - interrupts = <28 IRQ_TYPE_EDGE_RISING>; > - interrupt-parent = <&gpio1>; > - clocks = <&cclk>; > - vref-p-supply = <&ldo4_reg>; > - spi-max-frequency = <5000000>; > - ti,acquisition-time = <6>; > -}; > -- > 2.28.0 >