From: "Miclaus, Antoniu" <Antoniu.Miclaus@analog.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jic23@kernel.org" <jic23@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: RE: [PATCH v6 1/2] iio: frequency: adrf6780: add support for ADRF6780
Date: Tue, 20 Jul 2021 13:17:46 +0000 [thread overview]
Message-ID: <CY4PR03MB3399083DDE3A03C55D3153FE9BE29@CY4PR03MB3399.namprd03.prod.outlook.com> (raw)
In-Reply-To: <CAHp75VcNhJrp4YGZQu1ZB2J4ARtuT2T2p-72H1qn4F+KtZDVoQ@mail.gmail.com>
Hello Andy,
Thanks for the review:
> -----Original Message-----
> From: Andy Shevchenko <andy.shevchenko@gmail.com>
> Sent: Friday, July 16, 2021 5:53 PM
> To: Miclaus, Antoniu <Antoniu.Miclaus@analog.com>
> Cc: linux-iio@vger.kernel.org; linux-kernel@vger.kernel.org;
> jic23@kernel.org; devicetree@vger.kernel.org
> Subject: Re: [PATCH v6 1/2] iio: frequency: adrf6780: add support for
> ADRF6780
>
> [External]
>
> On Fri, Jul 16, 2021 at 2:43 PM Antoniu Miclaus
> <antoniu.miclaus@analog.com> wrote:
> >
> > The ADRF6780 is a silicon germanium (SiGe) design, wideband,
> > microwave upconverter optimized for point to point microwave
> > radio designs operating in the 5.9 GHz to 23.6 GHz frequency
> > range.
>
> > Datasheet:
> > https://www.analog.com/media/en/technical-documentation/data-
> sheets/ADRF6780.pdf
>
> Is it one line? If not, please put on one line and drop below the
> blank line so it will go as a tag.
Yes, it is one line.
>
> >
> > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
>
> First question is why not to use the regmap API (I have heard it has
> gained support of 17 bit)?
Initially that was the plan, but after this patch:
https://github.com/torvalds/linux/commit/4191f19792bf91267835eb090d970e9cd6277a65
the custom write formats for regmap allow the read only via cached registers.
Therefore, I preferred using spi transfers for write/read to/from the device.
> ...
>
> > + depends on COMMON_CLK
>
> Is it mandatory for any function inside the device?
Yes. It will serve as LO input to the device.
>
> ...
>
> > +static int adrf6780_spi_read(struct adrf6780_dev *dev, unsigned int reg,
> > + unsigned int *val)
> > +{
> > + int ret;
> > + struct spi_transfer t = {0};
>
> > + dev->data[0] = 0x80 | (reg << 1);
>
> This 0x80 I guess is pretty much standard and regmap SPI supports it.
>
> > + dev->data[1] = 0x0;
> > + dev->data[2] = 0x0;
> > +
> > + t.rx_buf = &dev->data[0];
> > + t.tx_buf = &dev->data[0];
> > + t.len = 3;
> > +
> > + ret = spi_sync_transfer(dev->spi, &t, 1);
> > + if (ret)
> > + return ret;
> > +
> > + *val = (get_unaligned_be24(&dev->data[0]) >> 1) & GENMASK(15, 0);
> > +
> > + return ret;
> > +}
>
> ...
>
> > + usleep_range(200, 250);
>
> Needs a comment.
Will add in next patch version.
>
> --
> With Best Regards,
> Andy Shevchenko
Regards,
Antoniu
next prev parent reply other threads:[~2021-07-20 13:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-16 11:42 [PATCH v6 1/2] iio: frequency: adrf6780: add support for ADRF6780 Antoniu Miclaus
2021-07-16 11:42 ` [PATCH v6 2/2] dt-bindings: iio: frequency: add adrf6780 doc Antoniu Miclaus
2021-07-17 14:21 ` Jonathan Cameron
2021-07-20 14:05 ` Miclaus, Antoniu
2021-07-16 14:53 ` [PATCH v6 1/2] iio: frequency: adrf6780: add support for ADRF6780 Andy Shevchenko
2021-07-20 13:17 ` Miclaus, Antoniu [this message]
2021-07-20 14:07 ` Andy Shevchenko
2021-07-20 14:33 ` Miclaus, Antoniu
2021-07-20 14:52 ` Andy Shevchenko
2021-07-17 13:26 ` Jonathan Cameron
2021-07-20 13:34 ` Miclaus, Antoniu
2021-07-24 16:26 ` Jonathan Cameron
2021-07-17 13:58 ` Jonathan Cameron
2021-07-19 0:35 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR03MB3399083DDE3A03C55D3153FE9BE29@CY4PR03MB3399.namprd03.prod.outlook.com \
--to=antoniu.miclaus@analog.com \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).