From: Rob Herring <robh@kernel.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Stephan Gerhold <stephan@gerhold.net>,
Lars-Peter Clausen <lars@metafoo.de>,
Linus Walleij <linus.walleij@linaro.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
Hans de Goede <hdegoede@redhat.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
~postmarketos/upstreaming@lists.sr.ht,
Nikita Travkin <nikita@trvn.ru>
Subject: Re: [PATCH 2/4] dt-bindings: iio: accel: bma255: Add bosch,bmc156_accel
Date: Thu, 29 Jul 2021 13:10:29 -0600 [thread overview]
Message-ID: <YQL9JSmpYq7Ht4FS@robh.at.kernel.org> (raw)
In-Reply-To: <20210724170318.771cbeeb@jic23-huawei>
On Sat, Jul 24, 2021 at 05:03:18PM +0100, Jonathan Cameron wrote:
> On Mon, 19 Jul 2021 13:21:54 +0200
> Stephan Gerhold <stephan@gerhold.net> wrote:
>
> > BMC156 is very smilar to BMC150, but it has only one accelerometer
> > interrupt pin. It would make sense if only INT1 was exposed but someone
> > at Bosch was crazy and decided to only have an INT2 pin.
> >
> > In this case, it does not make sense if the first interrupt pin is
> > treated as INT1 (since that pin does not exist). Add a note to the
> > bindings that the first interrupt pin is treated as INT2 for BMC156.
> >
> > Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
> > ---
> > .../bindings/iio/accel/bosch,bma255.yaml | 18 ++++++++++++++++++
> > 1 file changed, 18 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml b/Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml
> > index 897a1d808ef5..f7848e4a7b29 100644
> > --- a/Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml
> > +++ b/Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml
> > @@ -26,6 +26,7 @@ properties:
> > - bosch,bma255
> > - bosch,bma280
> > - bosch,bmc150_accel
> > + - bosch,bmc156_accel
> > - bosch,bmi055_accel
> >
> > # bma180 driver in Linux
> > @@ -49,6 +50,9 @@ properties:
> > the second (optional) interrupt listed must be the one connected to the
> > INT2 pin (if available). The type should be IRQ_TYPE_EDGE_RISING.
> >
> > + BMC156 does not have an INT1 pin, therefore the first interrupt pin is
> > + always treated as INT2.
>
> We 'could' enforce any name present for the bmc156 to be INT2, but we probably
> still want the fallback you have in the driver to handle the case of
> not interrupt-name provided.
>
> Rob, do you think it's worth the complexity for this corner case?
No.
Rob
next prev parent reply other threads:[~2021-07-29 19:10 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-19 11:21 [PATCH 0/4] iio: accel: bmc150: Add support for INT2 and BMC156 Stephan Gerhold
2021-07-19 11:21 ` [PATCH 1/4] dt-bindings: iio: accel: bma255: Add interrupt-names Stephan Gerhold
2021-07-19 13:57 ` Linus Walleij
2021-07-24 16:00 ` Jonathan Cameron
2021-07-19 11:21 ` [PATCH 2/4] dt-bindings: iio: accel: bma255: Add bosch,bmc156_accel Stephan Gerhold
2021-07-19 13:58 ` Linus Walleij
2021-07-24 16:03 ` Jonathan Cameron
2021-07-29 19:10 ` Rob Herring [this message]
2021-07-29 19:10 ` Rob Herring
2021-07-19 11:21 ` [PATCH 3/4] iio: accel: bmc150: Make it possible to configure INT2 instead of INT1 Stephan Gerhold
2021-07-19 14:07 ` Linus Walleij
2021-07-19 15:01 ` Andy Shevchenko
2021-07-19 15:10 ` Stephan Gerhold
2021-07-19 16:19 ` Andy Shevchenko
2021-07-19 17:26 ` Stephan Gerhold
2021-07-19 18:05 ` Andy Shevchenko
2021-07-19 18:36 ` Stephan Gerhold
2021-07-20 15:04 ` Andy Shevchenko
2021-07-24 16:19 ` Jonathan Cameron
2021-07-24 18:06 ` Jonathan Cameron
2021-07-19 11:21 ` [PATCH 4/4] iio: accel: bmc150: Add support for BMC156 Stephan Gerhold
2021-07-19 14:08 ` Linus Walleij
2021-07-24 16:12 ` Jonathan Cameron
2021-07-27 18:32 ` Stephan Gerhold
2021-07-31 18:04 ` Jonathan Cameron
2021-07-19 12:34 ` [PATCH 0/4] iio: accel: bmc150: Add support for INT2 and BMC156 Andy Shevchenko
2021-07-19 12:42 ` Stephan Gerhold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQL9JSmpYq7Ht4FS@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=nikita@trvn.ru \
--cc=stephan@gerhold.net \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).