linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
To: Beniamin Bia <beniamin.bia@analog.com>
Cc: jic23@kernel.org, lars@metafoo.de, Michael.Hennerich@analog.com,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	biabeniamin@outlook.com
Subject: Re: [PATCH v2 4/4] dt-bindings: iio: adc: Add AD7606B ADC documentation
Date: Wed, 7 Aug 2019 18:41:50 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.21.1908071830110.32509@vps.pmeerw.net> (raw)
In-Reply-To: <20190807133137.11185-4-beniamin.bia@analog.com>

On Wed, 7 Aug 2019, Beniamin Bia wrote:

minor comment below

> Documentation for AD7606B Analog to Digital Converter and software
> mode was added.
> 
> Signed-off-by: Beniamin Bia <beniamin.bia@analog.com>
> ---
> Changes in v2:
> -nothing changed
> 
>  Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
> index 509dbe9c84d2..2afe31747a70 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
> @@ -13,6 +13,7 @@ maintainers:
>  description: |
>    Analog Devices AD7606 Simultaneous Sampling ADC
>    https://www.analog.com/media/en/technical-documentation/data-sheets/ad7606_7606-6_7606-4.pdf
> +  https://www.analog.com/media/en/technical-documentation/data-sheets/AD7606B.pdf
>    https://www.analog.com/media/en/technical-documentation/data-sheets/AD7616.pdf
>  
>  properties:
> @@ -22,6 +23,7 @@ properties:
>        - adi,ad7606-8
>        - adi,ad7606-6
>        - adi,ad7606-4
> +      - adi,ad7606b
>        - adi,ad7616
>  
>    reg:
> @@ -87,7 +89,7 @@ properties:
>  
>    adi,sw-mode:
>      description:
> -      Software mode of operation, so far available only for ad7616.
> +      Software mode of operation, so far available only for ad7616 and ad7606B.

how about ad7606b to match the properties above?

>        It is enabled when all three oversampling mode pins are connected to
>        high level. The device is configured by the corresponding registers. If the
>        adi,oversampling-ratio-gpios property is defined, then the driver will set the
> 

-- 

Peter Meerwald-Stadler
Mobile: +43 664 24 44 418

  reply	other threads:[~2019-08-07 16:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-07 13:31 [PATCH v2 1/4] iio: adc: ad7606: Add support for AD7606B ADC Beniamin Bia
2019-08-07 13:31 ` [PATCH v2 2/4] MAINTAINERS: Add Beniamin Bia for AD7606 driver Beniamin Bia
2019-08-07 13:31 ` [PATCH v2 3/4] dt-bindings: iio: adc: Migrate AD7606 documentation to yaml Beniamin Bia
2019-08-21 20:24   ` Rob Herring
2020-01-13 17:32   ` Rob Herring
2019-08-07 13:31 ` [PATCH v2 4/4] dt-bindings: iio: adc: Add AD7606B ADC documentation Beniamin Bia
2019-08-07 16:41   ` Peter Meerwald-Stadler [this message]
2019-08-21 20:25   ` Rob Herring
2019-08-07 16:41 ` [PATCH v2 1/4] iio: adc: ad7606: Add support for AD7606B ADC Peter Meerwald-Stadler
2019-08-08 11:30   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1908071830110.32509@vps.pmeerw.net \
    --to=pmeerw@pmeerw.net \
    --cc=Michael.Hennerich@analog.com \
    --cc=beniamin.bia@analog.com \
    --cc=biabeniamin@outlook.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).