From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Pan Bian <bianpan2016@163.com>
Cc: Ferruh Yigit <fery@cypress.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: cyttsp4_core: fix use after free bug
Date: Tue, 12 Nov 2019 17:04:43 -0800 [thread overview]
Message-ID: <20191113010443.GM13374@dtor-ws> (raw)
In-Reply-To: <1572936379-6423-1-git-send-email-bianpan2016@163.com>
On Tue, Nov 05, 2019 at 02:46:19PM +0800, Pan Bian wrote:
> The device md->input is used after it is released. Setting the device
> data to NULL is unnecessary as the device is never used again. Instead,
> md->input should be assigned NULL to avoid accessing the freed memory
> accidently.
No, we are tearing up the device anyway, I'd leave it as it was, so I'll
drop this chunk and apply the rest.
Thank you.
--
Dmitry
prev parent reply other threads:[~2019-11-13 1:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 6:46 [PATCH] Input: cyttsp4_core: fix use after free bug Pan Bian
2019-11-13 1:04 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191113010443.GM13374@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=bianpan2016@163.com \
--cc=fery@cypress.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).