From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "zhengbin (A)" <zhengbin13@huawei.com>
Cc: pali.rohar@gmail.com, linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: alps - Remove unnecessary unlikely
Date: Wed, 13 Nov 2019 00:05:42 -0800 [thread overview]
Message-ID: <20191113080542.GN13374@dtor-ws> (raw)
In-Reply-To: <f9e1bf60-6936-4aea-090f-cc64a1fffa25@huawei.com>
On Wed, Nov 13, 2019 at 11:11:04AM +0800, zhengbin (A) wrote:
> ping
No, the preference is to keep the code here as is, thank you.
>
> On 2019/10/12 16:36, zhengbin wrote:
> > IS_ERR_OR_NULL already contains unlikely, there is no need
> > for another one.
> >
> > Signed-off-by: zhengbin <zhengbin13@huawei.com>
> > ---
> > drivers/input/mouse/alps.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
> > index 34700ed..ed16614 100644
> > --- a/drivers/input/mouse/alps.c
> > +++ b/drivers/input/mouse/alps.c
> > @@ -1476,7 +1476,7 @@ static void alps_report_bare_ps2_packet(struct psmouse *psmouse,
> > /* On V2 devices the DualPoint Stick reports bare packets */
> > dev = priv->dev2;
> > dev2 = psmouse->dev;
> > - } else if (unlikely(IS_ERR_OR_NULL(priv->dev3))) {
> > + } else if (IS_ERR_OR_NULL(priv->dev3)) {
> > /* Register dev3 mouse if we received PS/2 packet first time */
> > if (!IS_ERR(priv->dev3))
> > psmouse_queue_work(psmouse, &priv->dev3_register_work,
> > --
> > 2.7.4
> >
> >
> > .
> >
>
--
Dmitry
prev parent reply other threads:[~2019-11-13 8:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-12 8:36 [PATCH] Input: alps - Remove unnecessary unlikely zhengbin
2019-11-13 3:11 ` zhengbin (A)
2019-11-13 8:05 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191113080542.GN13374@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).