From: "Bruno Prémont" <bonbons@linux-vserver.org>
To: Jani Nikula <jani.nikula@intel.com>
Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
intel-gfx@lists.freedesktop.org, ville.syrjala@linux.intel.com,
linux-input@vger.kernel.org,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Jiri Kosina <jikos@kernel.org>
Subject: Re: [PATCH v2 11/14] HID: picoLCD: constify fb ops
Date: Mon, 2 Dec 2019 09:40:47 +0100 [thread overview]
Message-ID: <20191202094047.34525a7d@aether.lan.sysophe.eu> (raw)
In-Reply-To: <8678a9a3566279c881bb4db944850eef35d0a4bb.1575022735.git.jani.nikula@intel.com>
Hi Jani,
On Fri, 29 Nov 2019 12:29:41 Jani Nikula <jani.nikula@intel.com> wrote:
> Now that the fbops member of struct fb_info is const, we can start
> making the ops const as well.
>
> v2: fix typo (Christophe de Dinechin)
Fine with me.
I don't think going through drm-misc would trigger any conflict, but
adding Jiri to CC for the case there was any preference.
Acked-by: Bruno Prémont <bonbons@linux-vserver.org>
> Cc: Bruno Prémont <bonbons@linux-vserver.org>
> Cc: linux-input@vger.kernel.org
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/hid/hid-picolcd_fb.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/hid/hid-picolcd_fb.c b/drivers/hid/hid-picolcd_fb.c
> index e162a668fb7e..a549c42e8c90 100644
> --- a/drivers/hid/hid-picolcd_fb.c
> +++ b/drivers/hid/hid-picolcd_fb.c
> @@ -417,8 +417,7 @@ static int picolcd_set_par(struct fb_info *info)
> return 0;
> }
>
> -/* Note this can't be const because of struct fb_info definition */
> -static struct fb_ops picolcdfb_ops = {
> +static const struct fb_ops picolcdfb_ops = {
> .owner = THIS_MODULE,
> .fb_destroy = picolcd_fb_destroy,
> .fb_read = fb_sys_read,
next prev parent reply other threads:[~2019-12-02 8:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-29 10:29 [PATCH v2 00/14] video, drm, etc: constify fbops in struct fb_info Jani Nikula
2019-11-29 10:29 ` [PATCH v2 11/14] HID: picoLCD: constify fb ops Jani Nikula
2019-12-02 8:40 ` Bruno Prémont [this message]
2019-12-05 9:38 ` Jani Nikula
2019-12-08 0:07 ` Jiri Kosina
2019-11-29 15:40 ` [PATCH v2 00/14] video, drm, etc: constify fbops in struct fb_info Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191202094047.34525a7d@aether.lan.sysophe.eu \
--to=bonbons@linux-vserver.org \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=jikos@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).