From: Greg KH <greg@kroah.com>
To: Johan Hovold <johan@kernel.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, stable <stable@vger.kernel.org>
Subject: Re: [PATCH] Input: keyspan-remote: fix control-message timeouts
Date: Mon, 13 Jan 2020 19:26:12 +0100 [thread overview]
Message-ID: <20200113182612.GH411698@kroah.com> (raw)
In-Reply-To: <20200113171715.30621-1-johan@kernel.org>
On Mon, Jan 13, 2020 at 06:17:15PM +0100, Johan Hovold wrote:
> The driver was issuing synchronous uninterruptible control requests
> without using a timeout. This could lead to the driver hanging on probe
> due to a malfunctioning (or malicious) device until the device is
> physically disconnected. While sleeping in probe the driver prevents
> other devices connected to the same hub from being added to (or removed
> from) the bus.
>
> The USB upper limit of five seconds per request should be more than
> enough.
>
> Fixes: 99f83c9c9ac9 ("[PATCH] USB: add driver for Keyspan Digital Remote")
> Cc: stable <stable@vger.kernel.org> # 2.6.13
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
> drivers/input/misc/keyspan_remote.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
prev parent reply other threads:[~2020-01-13 18:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 17:17 [PATCH] Input: keyspan-remote: fix control-message timeouts Johan Hovold
2020-01-13 18:26 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200113182612.GH411698@kroah.com \
--to=greg@kroah.com \
--cc=dmitry.torokhov@gmail.com \
--cc=johan@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).