From: Dmitry Mastykin <dmastykin@astralinux.ru>
To: Bastien Nocera <hadess@hadess.net>,
Hans de Goede <hdegoede@redhat.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, dmastykin@astralinux.ru
Subject: [PATCH v3 2/2] Input: goodix - Fix spurious key release events
Date: Mon, 16 Mar 2020 10:53:05 +0300 [thread overview]
Message-ID: <20200316075302.3759-2-dmastykin@astralinux.ru> (raw)
In-Reply-To: <20200316075302.3759-1-dmastykin@astralinux.ru>
The goodix panel sends spurious interrupts after a 'finger up' event,
which always cause a timeout.
We were exiting the interrupt handler by reporting touch_num == 0, but
this was still processed as valid and caused the code to use the
uninitialised point_data, creating spurious key release events.
Report an error from the interrupt handler so as to avoid processing
invalid point_data further.
Signed-off-by: Dmitry Mastykin <dmastykin@astralinux.ru>
---
Changes in v3:
- Improve commit message
Changes in v2:
- Improve commit message
---
drivers/input/touchscreen/goodix.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c
index 04b5c7b..cc965fe 100644
--- a/drivers/input/touchscreen/goodix.c
+++ b/drivers/input/touchscreen/goodix.c
@@ -329,7 +329,7 @@ static int goodix_ts_read_input_report(struct goodix_ts_data *ts, u8 *data)
* The Goodix panel will send spurious interrupts after a
* 'finger up' event, which will always cause a timeout.
*/
- return 0;
+ return -ENOMSG;
}
static void goodix_ts_report_touch_8b(struct goodix_ts_data *ts, u8 *coor_data)
--
2.23.0
next prev parent reply other threads:[~2020-03-16 8:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 7:53 [PATCH v3 1/2] Input: goodix - Add support for more then one touch-key Dmitry Mastykin
2020-03-16 7:53 ` Dmitry Mastykin [this message]
2020-03-24 10:24 ` [PATCH v3 2/2] Input: goodix - Fix spurious key release events Bastien Nocera
2020-03-24 18:52 ` Dmitry Torokhov
2020-03-24 10:24 ` [PATCH v3 1/2] Input: goodix - Add support for more then one touch-key Bastien Nocera
2020-03-24 18:51 ` Dmitry Torokhov
2020-03-24 19:38 ` Dmitry Mastykin
2020-03-24 21:45 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200316075302.3759-2-dmastykin@astralinux.ru \
--to=dmastykin@astralinux.ru \
--cc=dmitry.torokhov@gmail.com \
--cc=hadess@hadess.net \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).