From: Peter Hutterer <peter.hutterer@who-t.net>
To: "Johnny.Chuang" <johnny.chuang@emc.com.tw>
Cc: 'Johnny Chuang' <johnny.chuang.emc@gmail.com>,
'Dmitry Torokhov' <dmitry.torokhov@gmail.com>,
'Benjamin Tissoires' <benjamin.tissoires@redhat.com>,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
'Rob Schonberger' <robsc@google.com>,
'James Chen' <james.chen@emc.com.tw>,
'Jennifer Tsai' <jennifer.tsai@emc.com.tw>,
'Paul Liang' <paul.liang@emc.com.tw>,
'Jeff Chuang' <jeff.chuang@emc.com.tw>
Subject: Re: [PATCH] Input: elants_i2c - support palm detection
Date: Mon, 30 Mar 2020 13:47:32 +1000 [thread overview]
Message-ID: <20200330034732.GA156101@jelly> (raw)
In-Reply-To: <001501d6062e$849afb60$8dd0f220$@emc.com.tw>
On Mon, Mar 30, 2020 at 08:59:51AM +0800, Johnny.Chuang wrote:
> > -----Original Message-----
> > From: Peter Hutterer [mailto:peter.hutterer@who-t.net]
> > Sent: Sunday, March 29, 2020 10:15 AM
> > To: Johnny Chuang
> > Cc: Dmitry Torokhov; Benjamin Tissoires; linux-kernel@vger.kernel.org;
> > linux-input@vger.kernel.org; Rob Schonberger; Johnny Chuang; James Chen;
> > Jennifer Tsai; Paul Liang; Jeff Chuang
> > Subject: Re: [PATCH] Input: elants_i2c - support palm detection
> >
> > On Thu, Mar 26, 2020 at 03:58:45PM +0800, Johnny Chuang wrote:
> > > From: Johnny Chuang <johnny.chuang@emc.com.tw>
> > >
> > > Elan define finger/palm detection on the least significant bit of byte
> 33.
> > > The default value is 1 for all firmwares, which report as
> MT_TOOL_FINGER.
> > > If firmware support palm detection, the bit will change to 0 and
> > > report as MT_TOOL_PALM when firmware detecting palm.
> > >
> > > Signed-off-by: Johnny Chuang <johnny.chuang@emc.com.tw>
> > > ---
> > > drivers/input/touchscreen/elants_i2c.c | 11 ++++++++++-
> > > 1 file changed, 10 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/input/touchscreen/elants_i2c.c
> > > b/drivers/input/touchscreen/elants_i2c.c
> > > index 14c577c..3b4d9eb3 100644
> > > --- a/drivers/input/touchscreen/elants_i2c.c
> > > +++ b/drivers/input/touchscreen/elants_i2c.c
> > > @@ -73,6 +73,7 @@
> > > #define FW_POS_STATE 1
> > > #define FW_POS_TOTAL 2
> > > #define FW_POS_XY 3
> > > +#define FW_POS_TOOL_TYPE 33
> > > #define FW_POS_CHECKSUM 34
> > > #define FW_POS_WIDTH 35
> > > #define FW_POS_PRESSURE 45
> > > @@ -842,6 +843,7 @@ static void elants_i2c_mt_event(struct elants_data
> > > *ts, u8 *buf) {
> > > struct input_dev *input = ts->input;
> > > unsigned int n_fingers;
> > > + unsigned int tool_type;
> > > u16 finger_state;
> > > int i;
> > >
> > > @@ -852,6 +854,12 @@ static void elants_i2c_mt_event(struct elants_data
> > *ts, u8 *buf)
> > > dev_dbg(&ts->client->dev,
> > > "n_fingers: %u, state: %04x\n", n_fingers, finger_state);
> > >
> > > + /* Note: all fingers have the same tool type */
> > > + if (buf[FW_POS_TOOL_TYPE] & 0x01)
> > > + tool_type = MT_TOOL_FINGER;
> > > + else
> > > + tool_type = MT_TOOL_PALM;
> > > +
> > > for (i = 0; i < MAX_CONTACT_NUM && n_fingers; i++) {
> > > if (finger_state & 1) {
> > > unsigned int x, y, p, w;
> > > @@ -867,7 +875,7 @@ static void elants_i2c_mt_event(struct elants_data
> > *ts, u8 *buf)
> > > i, x, y, p, w);
> > >
> > > input_mt_slot(input, i);
> > > - input_mt_report_slot_state(input, MT_TOOL_FINGER,
> true);
> > > + input_mt_report_slot_state(input, tool_type, true);
> > > input_event(input, EV_ABS, ABS_MT_POSITION_X, x);
> > > input_event(input, EV_ABS, ABS_MT_POSITION_Y, y);
> > > input_event(input, EV_ABS, ABS_MT_PRESSURE, p); @@
> > -1307,6 +1315,7
> > > @@ static int elants_i2c_probe(struct i2c_client *client,
> > > input_set_abs_params(ts->input, ABS_MT_POSITION_Y, 0, ts->y_max, 0,
> > 0);
> > > input_set_abs_params(ts->input, ABS_MT_TOUCH_MAJOR, 0, 255, 0, 0);
> > > input_set_abs_params(ts->input, ABS_MT_PRESSURE, 0, 255, 0, 0);
> > > + input_set_abs_params(ts->input, ABS_MT_TOOL_TYPE, 0,
> > MT_TOOL_MAX, 0,
> > > +0);
> >
> > if you're only reporting pen and palm, can we set this to MT_TOOL_PALM
> > instead? Otherwise you're indicating you may also send MT_TOOL_DIAL which
> > is unlikely on this hardware :)
> >
>
> Yes, we do not have MT_TOOL_DIAL on touch screen.
> So I need to modify MT_TOOL_MAX to MT_TOOL_PALM, right?
yes please.
Cheers,
Peter
>
> > Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net> otherwise
> >
> > Cheers,
> > Peter
> >
> > > input_abs_set_res(ts->input, ABS_MT_POSITION_X, ts->x_res);
> > > input_abs_set_res(ts->input, ABS_MT_POSITION_Y, ts->y_res);
> > > input_abs_set_res(ts->input, ABS_MT_TOUCH_MAJOR, 1);
> > > --
> > > 2.7.4
> > >
>
next prev parent reply other threads:[~2020-03-30 3:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 7:58 [PATCH] Input: elants_i2c - support palm detection Johnny Chuang
2020-03-29 2:14 ` Peter Hutterer
2020-03-30 0:59 ` Johnny.Chuang
2020-03-30 3:47 ` Peter Hutterer [this message]
2020-03-30 5:45 ` Johnny.Chuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200330034732.GA156101@jelly \
--to=peter.hutterer@who-t.net \
--cc=benjamin.tissoires@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=james.chen@emc.com.tw \
--cc=jeff.chuang@emc.com.tw \
--cc=jennifer.tsai@emc.com.tw \
--cc=johnny.chuang.emc@gmail.com \
--cc=johnny.chuang@emc.com.tw \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.liang@emc.com.tw \
--cc=robsc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).