From: Marco Felsch <m.felsch@pengutronix.de>
To: Fengping Yu <fengping.yu@mediatek.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-input@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v9 2/3] drivers: input: keyboard: Add mtk keypad driver
Date: Wed, 27 May 2020 11:09:48 +0200 [thread overview]
Message-ID: <20200527090948.tviafdsaaiuiso33@pengutronix.de> (raw)
In-Reply-To: <20200527083137.56566-3-fengping.yu@mediatek.com>
Hi,
just found another typo.
On 20-05-27 16:31, Fengping Yu wrote:
> From: "fengping.yu" <fengping.yu@mediatek.com>
...
> +static const struct of_device_id kpd_of_match[] = {
> + {.compatible = "mediatek, mt6779-keypad"},
^
This is wrong
> + {.compatible = "mediatek,kp"},
I would also drop the generic "mediatek,kp" compatible. Instead we
should list all supported SoCs here.
Regards,
Marco
> + {/* sentinel */}
> +};
> +
> +static struct platform_driver kpd_pdrv = {
> + .probe = kpd_pdrv_probe,
> + .driver = {
> + .name = MTK_KPD_NAME,
> + .of_match_table = kpd_of_match,
> + },
> +};
> +module_platform_driver(kpd_pdrv);
> +
> +MODULE_AUTHOR("Mediatek Corporation");
> +MODULE_DESCRIPTION("MTK Keypad (KPD) Driver");
> +MODULE_LICENSE("GPL");
> --
> 2.18.0
next prev parent reply other threads:[~2020-05-27 9:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 8:31 [PATCH v9] Add matrix keypad driver support for Mediatek SoCs Fengping Yu
[not found] ` <20200527083137.56566-3-fengping.yu@mediatek.com>
2020-05-27 9:00 ` [PATCH v9 2/3] drivers: input: keyboard: Add mtk keypad driver Marco Felsch
2020-05-27 9:50 ` Andy Shevchenko
2020-05-27 9:09 ` Marco Felsch [this message]
[not found] ` <20200527083137.56566-4-fengping.yu@mediatek.com>
2020-05-27 9:02 ` [PATCH v9 3/3] configs: defconfig: Add CONFIG_KEYBOARD_MTK_KPD=m Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200527090948.tviafdsaaiuiso33@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=fengping.yu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).