From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: linux-input@vger.kernel.org,
Vincent Huang <vincent.huang@tw.synaptics.com>,
Lyude Paul <lyude@redhat.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jiri Kosina <jikos@kernel.org>,
Andrew Duggan <aduggan@synaptics.com>,
Hans de Goede <hdegoede@redhat.com>,
Benjamin Tissoires <btissoir@redhat.com>,
Chris Heiny <chris.heiny@synaptics.com>
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>
Subject: [PATCH v3 1/2] Input: synaptics-rmi4 - support bootloader v8 in f34v7
Date: Thu, 1 Oct 2020 00:50:45 +0200 [thread overview]
Message-ID: <20200930225046.173190-2-Jason@zx2c4.com> (raw)
In-Reply-To: <20200930225046.173190-1-Jason@zx2c4.com>
With the recent addition of the F3A support, we can now accept
bootloader v8, which will help support recent Thinkpads.
Acked-by: Lyude Paul <lyude@redhat.com>
Cc: Vincent Huang <vincent.huang@tw.synaptics.com>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
---
drivers/input/rmi4/rmi_f34v7.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/input/rmi4/rmi_f34v7.c b/drivers/input/rmi4/rmi_f34v7.c
index 74f7c6f214ff..8cfaa2f19ed5 100644
--- a/drivers/input/rmi4/rmi_f34v7.c
+++ b/drivers/input/rmi4/rmi_f34v7.c
@@ -1364,9 +1364,12 @@ int rmi_f34v7_probe(struct f34_data *f34)
f34->bl_version = 6;
} else if (f34->bootloader_id[1] == 7) {
f34->bl_version = 7;
+ } else if (f34->bootloader_id[1] == 8) {
+ f34->bl_version = 8;
} else {
- dev_err(&f34->fn->dev, "%s: Unrecognized bootloader version\n",
- __func__);
+ dev_err(&f34->fn->dev, "%s: Unrecognized bootloader version: %d (%c) %d (%c)\n",
+ __func__, f34->bootloader_id[0], f34->bootloader_id[0],
+ f34->bootloader_id[1], f34->bootloader_id[1]);
return -EINVAL;
}
--
2.28.0
next prev parent reply other threads:[~2020-09-30 22:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 16:36 [PATCH] Input: synaptics - enable InterTouch for ThinkPad X1E/P1 2nd gen Jason A. Donenfeld
2020-09-30 11:07 ` Jason A. Donenfeld
2020-09-30 11:24 ` [PATCH v2] " Jason A. Donenfeld
2020-09-30 16:05 ` Lyude Paul
2020-09-30 16:18 ` Jason A. Donenfeld
2020-09-30 19:55 ` Lyude Paul
2020-09-30 22:55 ` Jason A. Donenfeld
2020-09-30 22:50 ` [PATCH v3 0/2] Support trackpoint and touchpad in Thinkpad P1 gen 2 / X1E gen 2 Jason A. Donenfeld
2020-09-30 22:50 ` Jason A. Donenfeld [this message]
2020-10-05 2:50 ` [PATCH v3 1/2] Input: synaptics-rmi4 - support bootloader v8 in f34v7 Dmitry Torokhov
2020-09-30 22:50 ` [PATCH v3 2/2] Input: synaptics - enable InterTouch for ThinkPad P1/X1E gen 2 Jason A. Donenfeld
2020-10-05 2:51 ` Dmitry Torokhov
2020-10-07 15:55 ` Jason A. Donenfeld
2020-10-11 9:00 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200930225046.173190-2-Jason@zx2c4.com \
--to=jason@zx2c4.com \
--cc=aduggan@synaptics.com \
--cc=btissoir@redhat.com \
--cc=chris.heiny@synaptics.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=vincent.huang@tw.synaptics.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).