From: kernel test robot <lkp@intel.com>
To: Andrej Valek <andrej.valek@siemens.com>,
chinyeow.sim.xt@renesas.com, martin.kepplinger@ginzinger.com,
dmitry.torokhov@gmail.com
Cc: kbuild-all@lists.01.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org,
Andrej Valek <andrej.valek@siemens.com>
Subject: Re: [PATCH] Input: st1232 - add support resolution reading
Date: Tue, 3 Nov 2020 02:05:37 +0800 [thread overview]
Message-ID: <202011030200.dKK6cKCM-lkp@intel.com> (raw)
In-Reply-To: <20201030093357.850-1-andrej.valek@siemens.com>
[-- Attachment #1: Type: text/plain, Size: 1535 bytes --]
Hi Andrej,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on input/next]
[also build test WARNING on v5.10-rc2 next-20201102]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Andrej-Valek/Input-st1232-add-support-resolution-reading/20201030-173555
base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
config: i386-randconfig-m021-20201102 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
smatch warnings:
drivers/input/touchscreen/st1232.c:86 st1232_ts_read_resolution() warn: inconsistent indenting
vim +86 drivers/input/touchscreen/st1232.c
74
75 static int st1232_ts_read_resolution(struct st1232_ts_data *ts, u16 *max_x,
76 u16 *max_y)
77 {
78 u8 *buf;
79 int error;
80
81 /* select resolution register */
82 error = st1232_ts_read_data(ts, REG_XY_RESOLUTION);
83 if (error)
84 return error;
85
> 86 buf = ts->read_buf;
87
88 *max_x = ((buf[0] & 0x0070) << 4) | buf[1];
89 *max_y = ((buf[0] & 0x0007) << 8) | buf[2];
90
91 return 0;
92 }
93
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 35484 bytes --]
next prev parent reply other threads:[~2020-11-02 18:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 9:33 [PATCH] Input: st1232 - add support resolution reading Andrej Valek
2020-11-02 18:05 ` kernel test robot [this message]
2020-11-03 7:39 ` [PATCH v2] " Andrej Valek
2020-11-12 1:53 ` Dmitry Torokhov
2020-11-12 8:11 ` Valek, Andrej
2020-11-20 7:17 ` Valek, Andrej
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202011030200.dKK6cKCM-lkp@intel.com \
--to=lkp@intel.com \
--cc=andrej.valek@siemens.com \
--cc=chinyeow.sim.xt@renesas.com \
--cc=dmitry.torokhov@gmail.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.kepplinger@ginzinger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).