From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Alexandru Ardelean <alexandru.ardelean@analog.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] Input: adp5589: use a single variable for error in probe
Date: Wed, 11 Nov 2020 16:37:38 -0800 [thread overview]
Message-ID: <20201112003738.GZ1003057@dtor-ws> (raw)
In-Reply-To: <20201111084833.40995-2-alexandru.ardelean@analog.com>
Hi Alexandru,
On Wed, Nov 11, 2020 at 10:48:28AM +0200, Alexandru Ardelean wrote:
> The 'error' & 'ret' variables are used. This is a bit of duplication.
> This change replaces the use of error with the 'ret' variable since the
> name is a bit more generic.
I really prefer variables that carry error codes/success and are used in
error paths to be called "error", and "ret" or "retval" to be used in
cases where we may return actual data.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2020-11-12 1:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 8:48 [PATCH 0/6] Input: adp5589: cleanup and use device-managed functions Alexandru Ardelean
2020-11-11 8:48 ` [PATCH 1/6] Input: adp5589: use a single variable for error in probe Alexandru Ardelean
2020-11-12 0:37 ` Dmitry Torokhov [this message]
2020-11-12 6:39 ` Ardelean, Alexandru
2020-11-12 6:51 ` Ardelean, Alexandru
2020-11-11 8:48 ` [PATCH 2/6] Input: adp5589: use devm_kzalloc() to allocate the kpad object Alexandru Ardelean
2020-11-11 8:48 ` [PATCH 3/6] Input: adp5589: use device-managed function in adp5589_keypad_add() Alexandru Ardelean
2020-11-11 8:48 ` [PATCH 4/6] Input: adp5589: remove setup/teardown hooks for gpios Alexandru Ardelean
2020-11-11 8:48 ` [PATCH 5/6] Input: adp5589: use devm_gpiochip_add_data() " Alexandru Ardelean
2020-11-11 8:48 ` [PATCH 6/6] Input: adp5589: use devm_add_action_or_reset() for register clear Alexandru Ardelean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201112003738.GZ1003057@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=alexandru.ardelean@analog.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).