From: Marco Felsch <m.felsch@pengutronix.de>
To: Alistair Francis <alistair@alistair23.me>
Cc: dmitry.torokhov@gmail.com, linux-input@vger.kernel.org,
linux-imx@nxp.com, kernel@pengutronix.de, alistair23@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/6] Add Wacom I2C support to rM2
Date: Fri, 22 Jan 2021 17:14:04 +0100 [thread overview]
Message-ID: <20210122161404.thcocfjghfqaga6t@pengutronix.de> (raw)
In-Reply-To: <20210121065643.342-1-alistair@alistair23.me>
Hi Alistair,
thanks for the patches. Before getting into the series please check all
your commit subjects. Also please check that you do only one logical
change per patch: e.g. adding DT-Support means: Add the dt-table and not
more.
I looking forward to your v2 :)
Regards,
Marco
On 21-01-20 22:56, Alistair Francis wrote:
> Add support to the reMarkable2 (rM2) for the Wacom I2C device.
>
> This is based on the reMarkable Linux fork and with this series I am
> able to probe the Wacom digitiser.
>
> Alistair Francis (6):
> devicetree/bindings: Initial commit of wacom,wacom-i2c
> input/touchscreen: Add device tree support to wacom_i2c
> touchscreen/wacom_i2c: Add support for distance and tilt x/y
> touchscreen/wacom_i2c: Clean up the query device fields
> touchscreen/wacom_i2c: Add support for vdd regulator
> arch/arm: reMarkable2: Enable wacom_i2c
>
> .../input/touchscreen/wacom,wacom-i2c.yaml | 48 +++++++
> .../devicetree/bindings/vendor-prefixes.yaml | 2 +
> arch/arm/boot/dts/imx7d-remarkable2.dts | 41 ++++++
> arch/arm/configs/imx_v6_v7_defconfig | 1 +
> drivers/input/touchscreen/wacom_i2c.c | 136 +++++++++++++++---
> 5 files changed, 205 insertions(+), 23 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/input/touchscreen/wacom,wacom-i2c.yaml
>
> --
> 2.29.2
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2021-01-22 16:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 6:56 [PATCH v2 0/6] Add Wacom I2C support to rM2 Alistair Francis
2021-01-21 6:56 ` [PATCH v2 1/6] devicetree/bindings: Initial commit of wacom,wacom-i2c Alistair Francis
2021-01-22 15:49 ` [PATCH v2 1/6] devicetree/bindings: Initial commit of wacom, wacom-i2c Marco Felsch
2021-01-21 6:56 ` [PATCH v2 2/6] input/touchscreen: Add device tree support to wacom_i2c Alistair Francis
2021-01-22 15:57 ` Marco Felsch
2021-01-21 6:56 ` [PATCH v2 3/6] touchscreen/wacom_i2c: Add support for distance and tilt x/y Alistair Francis
2021-01-22 16:00 ` Marco Felsch
2021-01-21 6:56 ` [PATCH v2 4/6] touchscreen/wacom_i2c: Clean up the query device fields Alistair Francis
2021-01-21 6:56 ` [PATCH v2 5/6] touchscreen/wacom_i2c: Add support for vdd regulator Alistair Francis
2021-01-21 6:56 ` [PATCH v2 6/6] arch/arm: reMarkable2: Enable wacom_i2c Alistair Francis
2021-01-22 15:32 ` Marco Felsch
2021-01-23 8:04 ` Alistair Francis
2021-01-22 16:14 ` Marco Felsch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210122161404.thcocfjghfqaga6t@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=alistair23@gmail.com \
--cc=alistair@alistair23.me \
--cc=dmitry.torokhov@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).