From: Hans de Goede <hdegoede@redhat.com>
To: Arnd Bergmann <arnd@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Marcos Paulo de Souza <mpdesouza@suse.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Po-Hsu Lin <po-hsu.lin@canonical.com>,
Kevin Locke <kevin@kevinlocke.name>,
Alexey Dobriyan <adobriyan@gmail.com>,
David Pedersen <limero1337@gmail.com>,
Rajat Jain <rajatja@google.com>, Chris Chiu <chiu@endlessos.org>,
Jiri Kosina <jkosina@suse.cz>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: i8042 - fix Pegatron C15B ID entry
Date: Tue, 23 Mar 2021 15:02:02 +0100 [thread overview]
Message-ID: <2187f843-f475-6d95-819a-ebb875b25d44@redhat.com> (raw)
In-Reply-To: <20210323130623.2302402-1-arnd@kernel.org>
Hi,
On 3/23/21 2:06 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The Zenbook Flip entry that was added overwrites a previous one
> because of a typo:
>
> In file included from drivers/input/serio/i8042.h:23,
> from drivers/input/serio/i8042.c:131:
> drivers/input/serio/i8042-x86ia64io.h:591:28: error: initialized field overwritten [-Werror=override-init]
> 591 | .matches = {
> | ^
> drivers/input/serio/i8042-x86ia64io.h:591:28: note: (near initialization for 'i8042_dmi_noselftest_table[0].matches')
>
> Add the missing separator between the two.
>
> Fixes: b5d6e7ab7fe7 ("Input: i8042 - add ASUS Zenbook Flip to noselftest list")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/input/serio/i8042-x86ia64io.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/serio/i8042-x86ia64io.h b/drivers/input/serio/i8042-x86ia64io.h
> index 9119e12a5778..a5a003553646 100644
> --- a/drivers/input/serio/i8042-x86ia64io.h
> +++ b/drivers/input/serio/i8042-x86ia64io.h
> @@ -588,6 +588,7 @@ static const struct dmi_system_id i8042_dmi_noselftest_table[] = {
> DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> DMI_MATCH(DMI_CHASSIS_TYPE, "10"), /* Notebook */
> },
> + }, {
> .matches = {
> DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> DMI_MATCH(DMI_CHASSIS_TYPE, "31"), /* Convertible Notebook */
>
next prev parent reply other threads:[~2021-03-23 14:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 13:06 [PATCH] Input: i8042 - fix Pegatron C15B ID entry Arnd Bergmann
2021-03-23 14:02 ` Hans de Goede [this message]
2021-03-23 14:42 ` Marcos Paulo de Souza
2021-03-23 16:58 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2187f843-f475-6d95-819a-ebb875b25d44@redhat.com \
--to=hdegoede@redhat.com \
--cc=adobriyan@gmail.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=chiu@endlessos.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=kevin@kevinlocke.name \
--cc=limero1337@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpdesouza@suse.com \
--cc=po-hsu.lin@canonical.com \
--cc=rajatja@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).