From: Lauri Jakku <lauri.jakku@pp.inet.fi>
To: Jiri Kosina <jikos@kernel.org>, Johan Hovold <johan@kernel.org>
Cc: Lauri Jakku <lja@iki.fi>,
oneukum@suse.com, benjamin.tissoires@redhat.com,
linux-input@vger.kernel.org, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v2] USB: HID: random timeout failures tackle try.
Date: Tue, 4 Feb 2020 14:55:41 +0200 [thread overview]
Message-ID: <3bb9f515-a5c6-3162-be5d-f9f984969882@pp.inet.fi> (raw)
In-Reply-To: <nycvar.YFH.7.76.2002041342460.26888@cbobk.fhfr.pm>
On 4.2.2020 14.43, Jiri Kosina wrote:
> On Tue, 4 Feb 2020, Johan Hovold wrote:
>
>>> Why modify usb-hid-core: No need to modify driver by driver.
>> Because you cannot decide how every use should handle timeouts.
>>
>> Just fix up the driver that needs this.
I think that if the device is left to errorneus state without
re-trying, it shows up to user very annoying. For example:
My mouse now has the problem with buttons: if i click left
button -> nothing may happen, and it is not functioning until
right button is pressed once. I make adaption to divide the
timeout by 100, and keep the try-loop in core.
I dont have list all the drivers that needs this -> better fix at
one common place.
> I believe it will actually not be a particular driver, but perhaps a set
> of devices with b0rked USB implementation, and we could just introduce
> (another, oh well) per-device quirk list if needed.
>
> Do we have any idea / indication how many devices out there actually
> require this?
Well i'd say quite many.
> Thanks,
>
--
Br,
Lauri J.
next prev parent reply other threads:[~2020-02-04 12:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 11:06 [PATCH v2] USB: HID: random timeout failures tackle try Lauri Jakku
2020-02-04 12:35 ` Johan Hovold
2020-02-04 12:43 ` Jiri Kosina
2020-02-04 12:55 ` Lauri Jakku [this message]
2020-02-04 15:05 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3bb9f515-a5c6-3162-be5d-f9f984969882@pp.inet.fi \
--to=lauri.jakku@pp.inet.fi \
--cc=benjamin.tissoires@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jikos@kernel.org \
--cc=johan@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lja@iki.fi \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).