linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hui Wang <hui.wang@canonical.com>
To: Jiri Kosina <jikos@kernel.org>
Cc: linux-input@vger.kernel.org, benjamin.tissoires@redhat.com
Subject: Re: [PATCH 2/2] HID: i2c-hid: Add a quirk to keep the power in shutdown
Date: Thu, 7 Jan 2021 19:46:49 +0800	[thread overview]
Message-ID: <41f85551-96a6-7bac-6dc9-02a66080e900@canonical.com> (raw)
In-Reply-To: <nycvar.YFH.7.76.2101071011130.13752@cbobk.fhfr.pm>


On 1/7/21 5:12 PM, Jiri Kosina wrote:
> On Fri, 4 Dec 2020, Hui Wang wrote:
>
>> On the latest Thinkpad Yoga laptop, the touchscreen module is wacom
>> I2C WACF2200 (056a:5276), we found the touchscreen could not work
>> after rebooting, needs to poweroff the machine then poweron the
>> machine to let it work.
>>
>> It is highly possible that this is a BIOS issue, but the windows
>> doesn't have this problem with the same BIOS.
>>
>> If keeping the power on when calling shutdown, the touchscreen could
>> work after rebooting. Let us add a quirk for it and apply the quirk
>> to this machine only.
> I wonder what do Windows do differently here. Perhaps they never put the
> i2c device to sleep while in shutdown anyway? Is there any downside to
> (not) doing the same?

It is highly possible the Windows doesn't sleep the i2c device in 
shutdown. When calling shutdown, it usually means reboot or poweroff the 
machine, so the sleep is meaningless in this situation. In other 
situations like users manually unload the i2c driver, maybe it will add 
a bit power consumption without sleeping the device.

Anyway, I will try to ask for help from vendor, maybe they could provide 
how Windows do when shutdown.

Thanks.

> Thanks,
>

  reply	other threads:[~2021-01-07 11:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-04 15:29 [PATCH 1/2] HID: i2c-hid: expand the quirk lookup table to support dmi_table Hui Wang
2020-12-04 15:29 ` [PATCH 2/2] HID: i2c-hid: Add a quirk to keep the power in shutdown Hui Wang
2021-01-07  9:12   ` Jiri Kosina
2021-01-07 11:46     ` Hui Wang [this message]
2021-01-08 15:01       ` Jiri Kosina
2021-01-26  8:57         ` Hui Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41f85551-96a6-7bac-6dc9-02a66080e900@canonical.com \
    --to=hui.wang@canonical.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).