From: Samuel Holland <samuel@sholland.org>
To: Hans de Goede <hdegoede@redhat.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Chen-Yu Tsai <wens@csie.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-sunxi@googlegroups.com
Subject: Re: [PATCH 3/3] Input: axp20x-pek - Enable wakeup for all AXP variants
Date: Tue, 14 Jan 2020 22:45:10 -0600 [thread overview]
Message-ID: <5fe8673b-99d7-c8ca-8457-503cb7f8adb3@sholland.org> (raw)
In-Reply-To: <df608e7c-a0bd-5077-c8e4-db661353e076@redhat.com>
Hi,
On 1/14/20 3:07 AM, Hans de Goede wrote:
> Hi,
>
> On 13-01-2020 22:26, Dmitry Torokhov wrote:
>> Hi Samuel,
>>
>> On Sun, Jan 12, 2020 at 09:20:32PM -0600, Samuel Holland wrote:
>>> There are many devices, including several mobile battery-powered
>>> devices, using other AXP variants as their PMIC. Enable them to use
>>> the power key as a wakeup source.
>>
>> Are these X86 or ARM devices? If anything, I'd prefer individual drivers
>> not declare themselves as wakeup sources unconditionally. With devic
>> etree we have standard "wakeup-source" property, but I am not quite sure
>> what's the latest on X86...
Currently wakeup is unconditional. After patch 2, even though it's enabled by
default, the wakeup source can be disabled by userspace:
- enable_irq_wake(axp20x_pek->irq_dbr);
+ device_init_wakeup(&pdev->dev, true);
This is a platform driver for an MFD cell. It does not have its own device tree
node.
(I see a lot of drivers in drivers/input/misc that generate KEY_POWER, and zero
of them reference "wakeup-source". It's a driver for a power button. Being a
wakeup source is half the purpose of its existence.)
> The AXP288 variant is X86, the other PMIC models are for ARM
> (to the best of my knowledge).
That's also my understanding.
> Regards,
>
> Hans
Regards,
Samuel
next prev parent reply other threads:[~2020-01-15 4:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 3:20 [PATCH 1/3] Input: axp20x-pek - Remove unique wakeup event handling Samuel Holland
2020-01-13 3:20 ` [PATCH 2/3] Input: axp20x-pek - Respect userspace wakeup configuration Samuel Holland
2020-01-13 4:47 ` kbuild test robot
2020-01-13 10:48 ` Hans de Goede
2020-01-13 21:38 ` Dmitry Torokhov
2020-01-14 4:50 ` kbuild test robot
2020-01-13 3:20 ` [PATCH 3/3] Input: axp20x-pek - Enable wakeup for all AXP variants Samuel Holland
2020-01-13 10:48 ` Hans de Goede
2020-01-13 21:26 ` Dmitry Torokhov
2020-01-14 9:07 ` Hans de Goede
2020-01-15 4:45 ` Samuel Holland [this message]
2020-01-13 10:41 ` [PATCH 1/3] Input: axp20x-pek - Remove unique wakeup event handling Hans de Goede
2020-01-13 10:58 ` Hans de Goede
2020-01-15 4:29 ` [linux-sunxi] " Samuel Holland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fe8673b-99d7-c8ca-8457-503cb7f8adb3@sholland.org \
--to=samuel@sholland.org \
--cc=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).