From: "Barnabás Pőcze" <pobrn@protonmail.com>
To: Roderick Colenbrander <roderick@gaikai.com>
Cc: Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
Chris Ye <lzye@google.com>,
Roderick Colenbrander <roderick.colenbrander@sony.com>
Subject: Re: [PATCH v2 02/13] HID: playstation: use DualSense MAC address as unique identifier.
Date: Thu, 07 Jan 2021 17:22:45 +0000 [thread overview]
Message-ID: <6Ltv1bAoULs4mgvrOMze4CKONmcJTA35zj6UEV5f-41SeBMD4GwLyN31wpyWJNpoLGKOK91AMx7Rx1MwMhmOzPoO3xST8KZdWHvtpdkpFn0=@protonmail.com> (raw)
In-Reply-To: <20210102223109.996781-3-roderick@gaikai.com>
Hi
2021. január 2., szombat 23:30 keltezéssel, Roderick Colenbrander írta:
> From: Roderick Colenbrander roderick.colenbrander@sony.com
>
> Use the DualSense MAC address as a unique identifier for the HID device.
>
> Signed-off-by: Roderick Colenbrander roderick.colenbrander@sony.com
>
> [...]
> /* Button masks for DualSense input report. */
> #define DS_BUTTONS0_HAT_SWITCH GENMASK(3, 0)
> #define DS_BUTTONS0_SQUARE BIT(4)
> @@ -132,6 +136,7 @@ static struct input_dev *ps_allocate_input_dev(struct hid_device *hdev, const ch
> return input_dev;
> }
>
> +
I think this extra empty line is not necessary here.
> static struct input_dev *ps_gamepad_create(struct hid_device *hdev)
> {
> struct input_dev *gamepad;
> @@ -162,6 +167,34 @@ static struct input_dev *ps_gamepad_create(struct hid_device *hdev)
> return gamepad;
> }
>
> +static int dualsense_get_mac_address(struct dualsense *ds)
> +{
> + uint8_t *buf;
> + int ret = 0;
> +
> + buf = kzalloc(DS_FEATURE_REPORT_PAIRING_INFO_SIZE, GFP_KERNEL);
> + if (!buf)
> + return -ENOMEM;
> +
> + ret = hid_hw_raw_request(ds->base.hdev, DS_FEATURE_REPORT_PAIRING_INFO, buf,
> + DS_FEATURE_REPORT_PAIRING_INFO_SIZE, HID_FEATURE_REPORT,
> + HID_REQ_GET_REPORT);
> + if (ret < 0)
> + goto err_free;
> + else if (ret != DS_FEATURE_REPORT_PAIRING_INFO_SIZE) {
As per coding style[1], please either use {} for all branches, or just drop the
`else` and maybe add a new line:
```
if (ret < 0)
goto ...
if (ret != ...) {
...
}
```
> + hid_err(ds->base.hdev, "failed to retrieve DualSense pairing info\n");
I think this message could be improved to better pinpoint the actual problem
that triggers it.
> + ret = -EINVAL;
> + goto err_free;
> + }
> +
> + /* Note MAC address is stored in little endian order. */
Maybe this comment would be better placed in `struct ps_device`?
> + memcpy(ds->base.mac_address, &buf[1], sizeof(ds->base.mac_address));
> +
> +err_free:
> + kfree(buf);
> + return ret;
> +}
> [...]
[1]: https://www.kernel.org/doc/html/latest/process/coding-style.html#placing-braces-and-spaces
Regards,
Barnabás Pőcze
next prev parent reply other threads:[~2021-01-07 17:23 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-02 22:30 [PATCH v2 00/13] HID: new driver for PS5 'DualSense' controller Roderick Colenbrander
2021-01-02 22:30 ` [PATCH v2 01/13] HID: playstation: initial DualSense USB support Roderick Colenbrander
2021-01-04 12:20 ` Jiri Kosina
2021-01-05 8:20 ` Benjamin Tissoires
2021-01-07 17:14 ` Barnabás Pőcze
2021-01-08 7:12 ` Roderick Colenbrander
2021-01-08 11:53 ` Barnabás Pőcze
2021-01-02 22:30 ` [PATCH v2 02/13] HID: playstation: use DualSense MAC address as unique identifier Roderick Colenbrander
2021-01-07 17:22 ` Barnabás Pőcze [this message]
2021-01-02 22:30 ` [PATCH v2 03/13] HID: playstation: add DualSense battery support Roderick Colenbrander
2021-01-07 17:50 ` Barnabás Pőcze
2021-01-02 22:31 ` [PATCH v2 04/13] HID: playstation: add DualSense touchpad support Roderick Colenbrander
2021-01-07 17:55 ` Barnabás Pőcze
2021-01-02 22:31 ` [PATCH v2 05/13] HID: playstation: add DualSense accelerometer and gyroscope support Roderick Colenbrander
2021-01-07 13:34 ` Florian Märkl
2021-01-08 5:51 ` Roderick Colenbrander
2021-01-07 18:51 ` Barnabás Pőcze
2021-01-08 6:06 ` Roderick Colenbrander
2021-01-08 12:01 ` Barnabás Pőcze
2021-01-08 17:15 ` Siarhei Vishniakou
2021-01-08 19:54 ` Roderick Colenbrander
2021-01-09 0:11 ` Siarhei Vishniakou
2021-01-11 0:06 ` Roderick Colenbrander
2021-01-02 22:31 ` [PATCH v2 06/13] HID: playstation: track devices in list Roderick Colenbrander
2021-01-07 20:13 ` Barnabás Pőcze
2021-01-02 22:31 ` [PATCH v2 07/13] HID: playstation: add DualSense Bluetooth support Roderick Colenbrander
2021-01-07 20:18 ` Barnabás Pőcze
2021-01-02 22:31 ` [PATCH v2 08/13] HID: playstation: add DualSense classic rumble support Roderick Colenbrander
2021-01-07 20:41 ` Barnabás Pőcze
2021-01-07 20:48 ` Barnabás Pőcze
2021-01-08 17:01 ` Roderick Colenbrander
2021-01-02 22:31 ` [PATCH v2 09/13] HID: playstation: add DualSense lightbar support Roderick Colenbrander
2021-01-07 21:01 ` Barnabás Pőcze
2021-01-02 22:31 ` [PATCH v2 10/13] HID: playstation: add microphone mute support for DualSense Roderick Colenbrander
2021-01-07 21:57 ` Barnabás Pőcze
2021-01-02 22:31 ` [PATCH v2 11/13] HID: playstation: add DualSense player LEDs support Roderick Colenbrander
2021-01-07 22:17 ` Barnabás Pőcze
2021-01-02 22:31 ` [PATCH v2 12/13] HID: playstation: DualSense set LEDs to default player id Roderick Colenbrander
2021-01-07 22:25 ` Barnabás Pőcze
2021-01-02 22:31 ` [PATCH v2 13/13] HID: playstation: report DualSense hardware and firmware version Roderick Colenbrander
2021-01-07 22:26 ` Barnabás Pőcze
2021-01-09 1:35 ` Roderick Colenbrander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='6Ltv1bAoULs4mgvrOMze4CKONmcJTA35zj6UEV5f-41SeBMD4GwLyN31wpyWJNpoLGKOK91AMx7Rx1MwMhmOzPoO3xST8KZdWHvtpdkpFn0=@protonmail.com' \
--to=pobrn@protonmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=lzye@google.com \
--cc=roderick.colenbrander@sony.com \
--cc=roderick@gaikai.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).