From: Linus Walleij <linus.walleij@linaro.org>
To: Stephan Gerhold <stephan@gerhold.net>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Linux Input <linux-input@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>
Subject: Re: [PATCH 3/3] Input: tm2-touchkey - add vddio regulator
Date: Sun, 6 Dec 2020 00:10:36 +0100 [thread overview]
Message-ID: <CACRpkdb9ZMJCPF9nGSX2jzkuj4g-3rCb4m0nHuBfrSFT-rPF_Q@mail.gmail.com> (raw)
In-Reply-To: <20201203131242.44397-3-stephan@gerhold.net>
On Thu, Dec 3, 2020 at 2:13 PM Stephan Gerhold <stephan@gerhold.net> wrote:
> The Samsung touchkey controllers are often used with external pull-up
> for the interrupt line and the I2C lines, so we might need to enable
> a regulator to bring the lines into usable state. Otherwise, this might
> cause spurious interrupts and reading from I2C will fail.
>
> Implement support for a "vddio-supply" that is enabled by the
> tm2-touchkey driver so that the regulator gets enabled when needed.
>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
next prev parent reply other threads:[~2020-12-05 23:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 13:12 [PATCH 1/3] dt-bindings: Input: tm2-touchkey - convert to yaml Stephan Gerhold
2020-12-03 13:12 ` [PATCH 2/3] dt-bindings: Input: tm2-touchkey - document vddio-supply Stephan Gerhold
2020-12-05 23:09 ` Linus Walleij
2020-12-06 12:28 ` Stephan Gerhold
2020-12-06 15:10 ` Linus Walleij
2020-12-09 20:12 ` Rob Herring
2020-12-10 3:50 ` Dmitry Torokhov
2020-12-03 13:12 ` [PATCH 3/3] Input: tm2-touchkey - add vddio regulator Stephan Gerhold
2020-12-05 23:10 ` Linus Walleij [this message]
2020-12-10 3:51 ` Dmitry Torokhov
2020-12-05 23:08 ` [PATCH 1/3] dt-bindings: Input: tm2-touchkey - convert to yaml Linus Walleij
2020-12-09 20:12 ` Rob Herring
2020-12-10 3:50 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdb9ZMJCPF9nGSX2jzkuj4g-3rCb4m0nHuBfrSFT-rPF_Q@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).