From: Doug Anderson <dianders@chromium.org>
To: Jiri Kosina <jkosina@suse.cz>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
Rob Herring <robh+dt@kernel.org>,
Stephen Boyd <swboyd@chromium.org>,
Andrea Borgia <andrea@borgia.bo.it>,
Jiri Kosina <jikos@kernel.org>,
Masahiro Yamada <masahiroy@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v8 4/4] HID: i2c-hid: Introduce goodix-i2c-hid using i2c-hid core
Date: Wed, 6 Jan 2021 08:44:05 -0800 [thread overview]
Message-ID: <CAD=FV=Wn2kBP-jL9g52ZQ_nHRi-BWwuW_oxs8CUv-k=6QcBFDA@mail.gmail.com> (raw)
In-Reply-To: <20201211142412.v8.4.If41b7d621633b94d56653c6d53f5f89c5274de7b@changeid>
Hi,
On Fri, Dec 11, 2020 at 2:25 PM Douglas Anderson <dianders@chromium.org> wrote:
>
> +static const struct goodix_i2c_hid_timing_data goodix_gt7375p_timing_data = {
> + .post_power_delay_ms = 10,
> + .post_gpio_reset_delay_ms = 120,
As I've been going through my holiday email I found that Goodix has
released a new datasheet (datasheet rev 0.6 from 2020-12-11) where
this moves from 120 ms to 180 ms. Sigh.
I'm hoping that we can just land it with the 120 though and then I'll
send a follow-up patch to change to 180. This will avoid spamming
everyone with a v9 of the patch series. Please yell if there are any
objections to that plan. I'd also be fine if you wanted to just
change it to 180 when landing it.
Thanks much!
-Doug
next prev parent reply other threads:[~2021-01-06 16:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 22:24 [PATCH v8 0/4] HID: i2c-hid: Reorganize to allow supporting goodix,gt7375p Douglas Anderson
2020-12-11 22:24 ` [PATCH v8 1/4] HID: i2c-hid: Reorganize so ACPI and OF are separate modules Douglas Anderson
2020-12-11 22:24 ` [PATCH v8 2/4] arm64: defconfig: Update config names for i2c-hid rejigger Douglas Anderson
2020-12-11 22:24 ` [PATCH v8 3/4] dt-bindings: input: HID: i2c-hid: Introduce bindings for the Goodix GT7375P Douglas Anderson
2020-12-11 22:24 ` [PATCH v8 4/4] HID: i2c-hid: Introduce goodix-i2c-hid using i2c-hid core Douglas Anderson
2021-01-06 16:44 ` Doug Anderson [this message]
2021-01-06 1:35 ` [PATCH v8 0/4] HID: i2c-hid: Reorganize to allow supporting goodix,gt7375p Doug Anderson
2021-01-08 17:52 ` Benjamin Tissoires
2021-01-13 15:08 ` Benjamin Tissoires
2021-01-13 15:58 ` Doug Anderson
2021-01-13 19:35 ` Benjamin Tissoires
2021-01-15 14:58 ` Benjamin Tissoires
2021-01-15 17:11 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=Wn2kBP-jL9g52ZQ_nHRi-BWwuW_oxs8CUv-k=6QcBFDA@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=andrea@borgia.bo.it \
--cc=benjamin.tissoires@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=jikos@kernel.org \
--cc=jkosina@suse.cz \
--cc=kai.heng.feng@canonical.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).