From: Rob Herring <robh+dt@kernel.org>
To: Bastien Nocera <hadess@hadess.net>
Cc: Benjamin Gaignard <benjamin.gaignard@st.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
Linux Input <linux-input@vger.kernel.org>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Yannick Fertre <yannick.fertre@st.com>
Subject: Re: [PATCH 2/2] dt-bindings: touchscreen: Convert Goodix touchscreen to json-schema
Date: Tue, 7 Jan 2020 12:02:52 -0600 [thread overview]
Message-ID: <CAL_JsqLGJehgW6c=GbyFSV8hL+WsUEkRzEBO0_kEka-d2nQ8pw@mail.gmail.com> (raw)
In-Reply-To: <99576d0367241bff637e82dddca839c40f672d86.camel@hadess.net>
On Tue, Jan 7, 2020 at 7:38 AM Bastien Nocera <hadess@hadess.net> wrote:
>
> On Tue, 2020-01-07 at 14:09 +0100, Benjamin Gaignard wrote:
> > Convert the Goodix binding to DT schema format using json-schema
>
> I don't have an opinion on the migration itself, but this really should
> not lose any of the descriptions that were in the old text file.
To some extent, yes. Any information specific to the device should be.
Anything generic can be dropped. I see 2 cases that should be kept:
> > - - reg : I2C address of the chip. Should be
> > 0x5d or 0x14
'I2C address of the chip' can be dropped as that's every 'reg'
property for I2C devices. The addresses can be expressed as
constraints.
> > - - irq-gpios : GPIO pin used for IRQ. The driver uses the
> > - interrupt gpio pin as output to reset the
> > device.
Also useful info.
Rob
next prev parent reply other threads:[~2020-01-07 18:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 13:09 [PATCH 0/2] Convert Goodix touchscreen to json-schema Benjamin Gaignard
2020-01-07 13:09 ` [PATCH 1/2] dt-bindings: touchscreen: Add touchscreen schema Benjamin Gaignard
2020-01-07 17:47 ` Rob Herring
2020-01-07 13:09 ` [PATCH 2/2] dt-bindings: touchscreen: Convert Goodix touchscreen to json-schema Benjamin Gaignard
2020-01-07 13:38 ` Bastien Nocera
2020-01-07 18:02 ` Rob Herring [this message]
2020-01-07 17:56 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqLGJehgW6c=GbyFSV8hL+WsUEkRzEBO0_kEka-d2nQ8pw@mail.gmail.com' \
--to=robh+dt@kernel.org \
--cc=benjamin.gaignard@st.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=hadess@hadess.net \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=yannick.fertre@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).