From: Roderick Colenbrander <roderick@gaikai.com>
To: "Barnabás Pőcze" <pobrn@protonmail.com>
Cc: Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
Chris Ye <lzye@google.com>,
Roderick Colenbrander <roderick.colenbrander@sony.com>
Subject: Re: [PATCH 13/13] HID: playstation: report DualSense hardware and firmware version.
Date: Sun, 27 Dec 2020 14:21:31 -0800 [thread overview]
Message-ID: <CANndSKn8xFGR3Y7x3rXxjhcNn89tt55o+RyvZkTp-aMzbF-JcA@mail.gmail.com> (raw)
In-Reply-To: <Wrry37udGNtUwRvYnSoet8ychKwk8YeD9NTEIjkfIMtrSmCXOc9h4oLcm5Uq77JV1AIgvP13uwxvXYuNAQF0jO_ZVp2M932WAPKQB5VdYGc=@protonmail.com>
Hi Barnabás,
Thanks for you great feedback.
On Sun, Dec 27, 2020 at 9:06 AM Barnabás Pőcze <pobrn@protonmail.com> wrote:
>
> Hi
>
>
> 2020. december 19., szombat 7:23 keltezéssel, Roderick Colenbrander írta:
>
> > diff --git a/drivers/hid/hid-playstation.c b/drivers/hid/hid-playstation.c
> > index a55375ac79a9..2f989da906f3 100644
> > --- a/drivers/hid/hid-playstation.c
> > +++ b/drivers/hid/hid-playstation.c
> > [...]
> > +static ssize_t ps_show_firmware_version(struct device *dev,
> > + struct device_attribute
> > + *attr, char *buf)
> > +{
> > + struct hid_device *hdev = to_hid_device(dev);
> > + struct ps_device *ps_dev = hid_get_drvdata(hdev);
> > +
> > + return snprintf(buf, PAGE_SIZE, "0x%08x\n", ps_dev->fw_version);
>
> `sysfs_emit()` is preferred over *printf().
Thanks, I wasn't aware of its existence. Looks like it was added
recently, but yeah it is a lot nicer.
>
> > +}
> > +
> > +static DEVICE_ATTR(firmware_version, 0444, ps_show_firmware_version, NULL);
> > +
> > +static ssize_t ps_show_hardware_version(struct device *dev,
> > + struct device_attribute
> > + *attr, char *buf)
> > +{
> > + struct hid_device *hdev = to_hid_device(dev);
> > + struct ps_device *ps_dev = hid_get_drvdata(hdev);
> > +
> > + return snprintf(buf, PAGE_SIZE, "0x%08x\n", ps_dev->hw_version);
>
> Same here.
>
>
> > +}
> > [...]
> > +static int dualsense_get_firmware_info(struct dualsense *ds)
> > +{
> > + uint8_t *buf;
> > + int ret = 0;
>
> Is there any reason it needs to be initialized?
>
>
> > +
> > + buf = kzalloc(DS_FEATURE_REPORT_FIRMWARE_INFO_SIZE, GFP_KERNEL);
> > + if (!buf)
> > + return -ENOMEM;
> > +
> > + ret = hid_hw_raw_request(ds->base.hdev, DS_FEATURE_REPORT_FIRMWARE_INFO, buf,
> > + DS_FEATURE_REPORT_FIRMWARE_INFO_SIZE, HID_FEATURE_REPORT,
> > + HID_REQ_GET_REPORT);
> > + if (ret < 0)
> > + goto err_free;
> > +
> > + ds->base.hw_version = get_unaligned_le32(&buf[24]);
> > + ds->base.fw_version = get_unaligned_le32(&buf[28]);
>
> Shouldn't the size of the reply be checked?
Good point, I added a check and returning -EINVAL now in case of a
size mismatch.
>
> > +
> > +err_free:
> > + kfree(buf);
> > + return ret;
> > +}
> > +
> > static int dualsense_get_mac_address(struct dualsense *ds)
> > {
> > uint8_t *buf;
> > @@ -1172,6 +1233,12 @@ static struct ps_device *dualsense_create(struct hid_device *hdev)
> > }
> > snprintf(hdev->uniq, sizeof(hdev->uniq), "%pMR", ds->base.mac_address);
> >
> > + ret = dualsense_get_firmware_info(ds);
> > + if (ret < 0) {
> > + hid_err(hdev, "Failed to get firmware info from DualSense\n");
> > + return ERR_PTR(ret);
> > + }
> > +
> > ret = ps_devices_list_add((struct ps_device *)ds);
> > if (ret < 0)
> > return ERR_PTR(ret);
> > @@ -1241,6 +1308,12 @@ static struct ps_device *dualsense_create(struct hid_device *hdev)
> > /* Set player LEDs to our player id. */
> > dualsense_set_player_leds(ds);
> >
> > + /* Reporting hardware and firmware is important as there are frequent updates, which
> > + * can change behavior.
> > + */
> > + hid_info(hdev, "Registered DualSense controller hw_version=%x fw_version=%x\n",
> > + ds->base.hw_version, ds->base.fw_version);
> > +
> > return (struct ps_device *)ds;
> >
> > err:
> > @@ -1295,6 +1368,12 @@ static int ps_probe(struct hid_device *hdev, const struct hid_device_id *id)
> > goto err_close;
> > }
> >
> > + ret = sysfs_create_group(&hdev->dev.kobj, &ps_device_attribute_group);
>
> It's a minor thing, but I think `device_{add,remove}_group()` would be better
> here in the sense that it expresses the fact that the group is added to a device,
> not just any object better.
Agreed, that's nicer I wasn't aware of it. I try to follow what other
hid drivers do and they all used the kobj directly, which honestly
felt nasty. Will change it to this.
>
> > + if (ret < 0) {
> > + hid_err(hdev, "Failed to register sysfs nodes.\n");
> > + goto err_close;
> > + }
> > +
> > return ret;
> >
> > err_close:
> > @@ -1313,6 +1392,8 @@ static void ps_remove(struct hid_device *hdev)
> >
> > hid_hw_close(hdev);
> > hid_hw_stop(hdev);
> > +
> > + sysfs_remove_group(&hdev->dev.kobj, &ps_device_attribute_group);
> > }
> >
> > static const struct hid_device_id ps_devices[] = {
> > --
> > 2.26.2
>
>
> Regards,
> Barnabás Pőcze
Thanks,
Roderick
next prev parent reply other threads:[~2020-12-27 22:22 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-19 6:23 [PATCH 00/13] HID: new driver for PS5 'DualSense' controller Roderick Colenbrander
2020-12-19 6:23 ` [PATCH 01/13] HID: playstation: initial DualSense USB support Roderick Colenbrander
2020-12-27 16:23 ` Barnabás Pőcze
2020-12-27 23:04 ` Roderick Colenbrander
2020-12-29 19:12 ` Barnabás Pőcze
2020-12-31 0:08 ` Barnabás Pőcze
2020-12-31 1:08 ` Roderick Colenbrander
2020-12-19 6:23 ` [PATCH 02/13] HID: playstation: use DualSense MAC address as unique identifier Roderick Colenbrander
2020-12-19 6:23 ` [PATCH 03/13] HID: playstation: add DualSense battery support Roderick Colenbrander
2020-12-19 6:23 ` [PATCH 04/13] HID: playstation: add DualSense touchpad support Roderick Colenbrander
2020-12-26 2:14 ` Samuel Čavoj
2020-12-26 22:27 ` Roderick Colenbrander
2020-12-29 19:49 ` Barnabás Pőcze
2020-12-29 21:44 ` Roderick Colenbrander
2020-12-19 6:23 ` [PATCH 05/13] HID: playstation: add DualSense accelerometer and gyroscope support Roderick Colenbrander
2020-12-19 6:23 ` [PATCH 06/13] HID: playstation: track devices in list Roderick Colenbrander
2020-12-19 6:23 ` [PATCH 07/13] HID: playstation: add DualSense Bluetooth support Roderick Colenbrander
2020-12-19 6:23 ` [PATCH 08/13] HID: playstation: add DualSense classic rumble support Roderick Colenbrander
2020-12-19 6:23 ` [PATCH 09/13] HID: playstation: add DualSense lightbar support Roderick Colenbrander
2020-12-27 14:41 ` Barnabás Pőcze
2020-12-28 21:26 ` Roderick Colenbrander
2020-12-29 18:59 ` Barnabás Pőcze
2020-12-29 19:54 ` Roderick Colenbrander
2020-12-29 20:22 ` Barnabás Pőcze
2020-12-19 6:23 ` [PATCH 10/13] HID: playstation: add microphone mute support for DualSense Roderick Colenbrander
2020-12-19 6:23 ` [PATCH 11/13] HID: playstation: add DualSense player LEDs support Roderick Colenbrander
2020-12-26 19:27 ` Samuel Čavoj
2020-12-26 23:07 ` Roderick Colenbrander
2020-12-27 14:27 ` Barnabás Pőcze
2020-12-28 22:02 ` Roderick Colenbrander
2020-12-29 18:49 ` Barnabás Pőcze
2020-12-19 6:23 ` [PATCH 12/13] HID: playstation: DualSense set LEDs to default player id Roderick Colenbrander
2020-12-27 0:08 ` Samuel Čavoj
2020-12-27 23:07 ` Roderick Colenbrander
2020-12-19 6:23 ` [PATCH 13/13] HID: playstation: report DualSense hardware and firmware version Roderick Colenbrander
2020-12-27 17:06 ` Barnabás Pőcze
2020-12-27 22:21 ` Roderick Colenbrander [this message]
2020-12-27 22:27 ` Roderick Colenbrander
2020-12-27 22:37 ` Barnabás Pőcze
2020-12-28 22:45 ` Roderick Colenbrander
2020-12-29 15:10 ` Barnabás Pőcze
2020-12-19 8:38 ` [PATCH 00/13] HID: new driver for PS5 'DualSense' controller Bastien Nocera
2020-12-19 22:39 ` Roderick.Colenbrander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANndSKn8xFGR3Y7x3rXxjhcNn89tt55o+RyvZkTp-aMzbF-JcA@mail.gmail.com \
--to=roderick@gaikai.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=lzye@google.com \
--cc=pobrn@protonmail.com \
--cc=roderick.colenbrander@sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).