From: "Valek, Andrej" <andrej.valek@siemens.com>
To: Hans de Goede <hdegoede@redhat.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "nick@shmanahar.org" <nick@shmanahar.org>,
"hadess@hadess.net" <hadess@hadess.net>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: RE: [PATCH 1/3] Input: goodix - add option to disable firmware loading
Date: Fri, 30 Oct 2020 11:02:58 +0000 [thread overview]
Message-ID: <DB8PR10MB3977770B9D7BF21130A4D95592150@DB8PR10MB3977.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <a5964429-a472-6b78-e53c-69b4cb115b94@redhat.com>
Hi Hans,
I am not saying, that just configuration loading took such a long time. Thu full process including configuration and FW loading takes it.
Means that I would like to prevent this situation, but keep the old scenario as a default behavior.
Regards,
Andrej
> Hi,
>
> On 10/29/20 9:36 PM, Dmitry Torokhov wrote:
>> Hi Andrej,
>>
> On Thu, Oct 29, 2020 at 06:03:11PM +0100, Andrej Valek wrote:
>>> Firmware file loadind for GT911 controller takes too much time (~60s).
>>> There is no check that configuration is the same which is already present.
>>> This happens always during boot, which makes touchscreen unusable.
>>>
>>> Add there an option to prevent firmware file loading, but keep it
>>> enabled by default.
>>
>> I thought that Goodix was losing firmware loading at poweroff. Is this
>> not the case with this model?
>
> So first of all there are 2 sorts of firmware involved with the Goodix touchscreen controllers, the actual firmware and a > block of config data for that firmware which I presume adjusts it for the specific (model of) the digitizer which is attached.
>
> ATM the mainline Linux driver does not support models where the actual firmware itself needs to be loaded (because they only have RAM, so they come up without firmware).
>
> I do have one model tablet with a ROM-less goodix touchpad controller, so if I ever find the time I might add support for loading the actual firmware.
>
> So what we are talking about here is just loading the config data and I'm a bit surprised that this take so long.
>
>> Adding Hans as he was working with this driver/code.
>
> With all that said I have no objection to this change.
>
> Regards,
>
> Hans
>
>
>
>>
>>>
>>> Signed-off-by: Andrej Valek <andrej.valek@siemens.com>
>>> ---
>>> drivers/input/touchscreen/goodix.c | 4 +++-
>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/input/touchscreen/goodix.c
>>> b/drivers/input/touchscreen/goodix.c
>>> index 02c75ea385e08..44336ecd2acdf 100644
>>> --- a/drivers/input/touchscreen/goodix.c
>>> +++ b/drivers/input/touchscreen/goodix.c
>>> @@ -941,7 +941,9 @@ static int goodix_get_gpio_config(struct goodix_ts_data *ts)
>>> default:
>>> if (ts->gpiod_int && ts->gpiod_rst) {
>>> ts->reset_controller_at_probe = true;
>>> - ts->load_cfg_from_disk = true;
>>> + /* Prevent cfg loading for each start */
>>> + ts->load_cfg_from_disk = !device_property_read_bool(dev,
>>> + "touchscreen-do-not-load-fw");
>>> ts->irq_pin_access_method = IRQ_PIN_ACCESS_GPIO;
>>> }
>>> }
>>> --
>>> 2.20.1
>>>
>>
>> Thanks.
>>
next prev parent reply other threads:[~2020-10-30 11:03 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 17:03 [PATCH 0/3] Firmware loading option Andrej Valek
2020-10-29 17:03 ` [PATCH 1/3] Input: goodix - add option to disable firmware loading Andrej Valek
2020-10-29 20:36 ` Dmitry Torokhov
2020-10-30 8:45 ` Valek, Andrej
2020-10-30 9:56 ` Hans de Goede
2020-10-30 11:02 ` Valek, Andrej [this message]
2020-11-23 6:53 ` Dmitry Torokhov
2020-11-23 8:46 ` Hans de Goede
2020-11-10 9:07 ` [PATCH v3 1/4] " Andrej Valek
2020-11-10 18:15 ` [PATCH v4 " Andrej Valek
2020-10-29 17:03 ` [PATCH 2/3] dt-bindings: goodix Andrej Valek
2020-11-04 21:44 ` Rob Herring
2020-11-10 9:07 ` [PATCH v3 2/4] dt-bindings: touchscreen: goodix: add info about disabling FW loading Andrej Valek
2020-11-10 13:43 ` Rob Herring
2020-11-10 18:15 ` [PATCH v4 " Andrej Valek
2020-11-16 17:08 ` Rob Herring
2020-10-29 17:03 ` [PATCH 3/3] Input: atmel_mxt_ts - add option to disable firmware loading Andrej Valek
2020-11-10 9:07 ` [PATCH v3 3/4] " Andrej Valek
2020-11-10 18:15 ` [PATCH v4 " Andrej Valek
2020-11-23 6:56 ` Dmitry Torokhov
2020-11-06 10:05 ` [PATCH v2 0/3] Firmware loading option Andrej Valek
2020-11-06 10:05 ` [PATCH v2 1/3] Input: st1232 - add support resolution reading Andrej Valek
2020-11-10 9:07 ` [PATCH v3 4/4] " Andrej Valek
2020-11-10 18:15 ` [PATCH v4 " Andrej Valek
2020-11-06 10:05 ` [PATCH v2 2/3] dt-bindings: goodix Andrej Valek
2020-11-09 21:37 ` Rob Herring
2020-11-06 10:05 ` [PATCH v2 3/3] Input: goodix - add option to disable firmware loading Andrej Valek
2020-11-10 9:07 ` [PATCH v3 0/4] Firmware loading option Andrej Valek
2020-11-10 18:15 ` [PATCH v4 " Andrej Valek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB8PR10MB3977770B9D7BF21130A4D95592150@DB8PR10MB3977.EURPRD10.PROD.OUTLOOK.COM \
--to=andrej.valek@siemens.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=hadess@hadess.net \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nick@shmanahar.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).