From: 'Dmitry Torokhov' <dmitry.torokhov@gmail.com>
To: jingle <jingle.wu@emc.com.tw>
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
phoenix@emc.com.tw, josh.chen@emc.com.tw, dave.wang@emc.com.tw
Subject: Re: [PATCH 1/2] Input: elan_i2c - Add new trackpoint report type 0x5F.
Date: Thu, 10 Dec 2020 19:04:58 -0800 [thread overview]
Message-ID: <X9Lh2n42om+SNEFx@google.com> (raw)
In-Reply-To: <004b01d6cf66$b1a8c590$14fa50b0$@emc.com.tw>
Hi Jingle,
On Fri, Dec 11, 2020 at 10:38:22AM +0800, jingle wrote:
> HI Dmitry:
Please do not top post on the kernel mailing lists.
>
> I would prefer if we validated report length versus the packet type before
> accepting it.
>
> -> If the tracking point report is 0x5F, the report length is 7, but the
> touchpad report length is 32.
> -> So, report length will be different with this module.
Right, but we could check the report type when we receive the data and
refuse it if length does not match what is expected for the report type
received. This can happen before we pass the data on to the
elan_i2c_core.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2020-12-11 3:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 9:07 [PATCH 1/2] Input: elan_i2c - Add new trackpoint report type 0x5F jingle.wu
2020-12-10 6:14 ` Dmitry Torokhov
2020-12-11 2:38 ` jingle
2020-12-11 3:04 ` 'Dmitry Torokhov' [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-12-11 7:15 jingle.wu
2020-12-11 21:48 ` Dmitry Torokhov
2020-12-07 8:50 jingle.wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X9Lh2n42om+SNEFx@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=dave.wang@emc.com.tw \
--cc=jingle.wu@emc.com.tw \
--cc=josh.chen@emc.com.tw \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phoenix@emc.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).