linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Charles Wang <charles.goodix@gmail.com>
Cc: hadess@hadess.net, hdegoede@redhat.com,
	neil.armstrong@linaro.org, hughsient@gmail.com,
	broonie@kernel.org, jeff@labundy.com,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Input: goodix-berlin - Add sysfs interface for reading and writing touch IC registers
Date: Mon, 13 May 2024 14:33:15 -0700	[thread overview]
Message-ID: <ZkKHGy0qvFzSoVhl@google.com> (raw)
In-Reply-To: <20240513123444.11617-1-charles.goodix@gmail.com>

Hi Charles,

On Mon, May 13, 2024 at 08:33:37PM +0800, Charles Wang wrote:
> +
> +const struct attribute_group *goodix_berlin_groups[] = {
> +	&goodix_berlin_attr_group,
> +	NULL,
> +};

This symbol needs to be exportedsymbol needs to be exported..

Thanks.

-- 
Dmitry

  reply	other threads:[~2024-05-13 21:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-13 12:33 [PATCH v2] Input: goodix-berlin - Add sysfs interface for reading and writing touch IC registers Charles Wang
2024-05-13 21:33 ` Dmitry Torokhov [this message]
2024-05-14 11:41   ` Charles Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZkKHGy0qvFzSoVhl@google.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=broonie@kernel.org \
    --cc=charles.goodix@gmail.com \
    --cc=hadess@hadess.net \
    --cc=hdegoede@redhat.com \
    --cc=hughsient@gmail.com \
    --cc=jeff@labundy.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neil.armstrong@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).