From: "Blaž Hrastnik" <blaz@mxxn.io>
To: "Benjamin Tissoires" <benjamin.tissoires@redhat.com>
Cc: "Jiri Kosina" <jikos@kernel.org>,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] HID: Improve Windows Precision Touchpad detection.
Date: Thu, 07 Nov 2019 18:06:21 +0900 [thread overview]
Message-ID: <fe67c7d0-1671-4bc4-af9f-7207d1f1a18e@www.fastmail.com> (raw)
In-Reply-To: <CAO-hwJKJvkW2_Dif4+P7ebBXwb-tLk+PHqks7yqevVZ-CHyTCQ@mail.gmail.com>
I've submitted a test containing the Surface Book 2 descriptor.
https://gitlab.freedesktop.org/libevdev/hid-tools/merge_requests/59
Blaž
On Thu, 7 Nov 2019, at 17:48, Benjamin Tissoires wrote:
> Hi Blaž,
>
> On Wed, Nov 6, 2019 at 12:03 PM Blaž Hrastnik <blaz@mxxn.io> wrote:
> >
> > Per Microsoft spec, usage 0xC5 (page 0xFF) returns a blob containing
> > data used to verify the touchpad as a Windows Precision Touchpad.
> >
> > 0x85, REPORTID_PTPHQA, // REPORT_ID (PTPHQA)
> > 0x09, 0xC5, // USAGE (Vendor Usage 0xC5)
> > 0x15, 0x00, // LOGICAL_MINIMUM (0)
> > 0x26, 0xff, 0x00, // LOGICAL_MAXIMUM (0xff)
> > 0x75, 0x08, // REPORT_SIZE (8)
> > 0x96, 0x00, 0x01, // REPORT_COUNT (0x100 (256))
> > 0xb1, 0x02, // FEATURE (Data,Var,Abs)
> >
> > However, some devices, namely Microsoft's Surface line of products
> > instead implement a "segmented device certification report" (usage 0xC6)
> > which returns the same report, but in smaller chunks.
> >
> > 0x06, 0x00, 0xff, // USAGE_PAGE (Vendor Defined)
> > 0x85, REPORTID_PTPHQA, // REPORT_ID (PTPHQA)
> > 0x09, 0xC6, // USAGE (Vendor usage for segment #)
> > 0x25, 0x08, // LOGICAL_MAXIMUM (8)
> > 0x75, 0x08, // REPORT_SIZE (8)
> > 0x95, 0x01, // REPORT_COUNT (1)
> > 0xb1, 0x02, // FEATURE (Data,Var,Abs)
> > 0x09, 0xC7, // USAGE (Vendor Usage)
> > 0x26, 0xff, 0x00, // LOGICAL_MAXIMUM (0xff)
> > 0x95, 0x20, // REPORT_COUNT (32)
> > 0xb1, 0x02, // FEATURE (Data,Var,Abs)
> >
> > By expanding Win8 touchpad detection to also look for the segmented
> > report, all Surface touchpads are now properly recognized by
> > hid-multitouch.
> >
> > Signed-off-by: Blaž Hrastnik <blaz@mxxn.io>
> > ---
>
> This looks good to me.
> We *could* shorten the ifs and make only one conditional, but I find
> it this way more readable and future proof.
>
> There is just one last step required before we merge this: add a
> regression test so we ensure we do not break it in the future.
>
> It should be merely a matter of sending a MR to
> https://gitlab.freedesktop.org/libevdev/hid-tools.
> It should consist in adding the report descriptor in the same way we
> have
> https://gitlab.freedesktop.org/libevdev/hid-tools/blob/master/tests/test_multitouch.py#L1656-1658.
> Then, make sure an unpatched kernel breaks the multitouch test (sudo
> pytest-3 -k 'multitouch and TestPTP') and that a patched kernel is
> fixed.
>
> Cheers,
> Benjamin
>
> > drivers/hid/hid-core.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> > index 63fdbf09b044..2af597cd5d65 100644
> > --- a/drivers/hid/hid-core.c
> > +++ b/drivers/hid/hid-core.c
> > @@ -742,6 +742,10 @@ static void hid_scan_feature_usage(struct hid_parser *parser, u32 usage)
> > if (usage == 0xff0000c5 && parser->global.report_count == 256 &&
> > parser->global.report_size == 8)
> > parser->scan_flags |= HID_SCAN_FLAG_MT_WIN_8;
> > +
> > + if (usage == 0xff0000c6 && parser->global.report_count == 1 &&
> > + parser->global.report_size == 8)
> > + parser->scan_flags |= HID_SCAN_FLAG_MT_WIN_8;
> > }
> >
> > static void hid_scan_collection(struct hid_parser *parser, unsigned type)
> > --
> > 2.23.0
> >
>
>
next prev parent reply other threads:[~2019-11-07 9:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 11:02 [PATCH] HID: Improve Windows Precision Touchpad detection Blaž Hrastnik
2019-11-07 8:48 ` Benjamin Tissoires
2019-11-07 9:06 ` Blaž Hrastnik [this message]
2019-11-18 10:04 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe67c7d0-1671-4bc4-af9f-7207d1f1a18e@www.fastmail.com \
--to=blaz@mxxn.io \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).