From: Jiri Kosina <jikos@kernel.org>
To: "Filipe Laíns" <lains@archlinux.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: logitech-dj: add debug msg when exporting a HID++ report descriptors
Date: Wed, 12 Feb 2020 14:45:08 +0100 (CET) [thread overview]
Message-ID: <nycvar.YFH.7.76.2002121445030.3144@cbobk.fhfr.pm> (raw)
In-Reply-To: <20200113192300.2482096-1-lains@archlinux.org>
On Mon, 13 Jan 2020, Filipe Laíns wrote:
> When exporting all other types of report descriptors we print a debug
> message. Not doing so for HID++ descriptors makes unaware users think
> that no HID++ descriptor was exported.
>
> Signed-off-by: Filipe Laíns <lains@archlinux.org>
> ---
> drivers/hid/hid-logitech-dj.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c
> index cc7fc71d8b05..8f17a29b5a94 100644
> --- a/drivers/hid/hid-logitech-dj.c
> +++ b/drivers/hid/hid-logitech-dj.c
> @@ -1368,6 +1368,8 @@ static int logi_dj_ll_parse(struct hid_device *hid)
> }
>
> if (djdev->reports_supported & HIDPP) {
> + dbg_hid("%s: sending a HID++ descriptor, reports_supported: %llx\n",
> + __func__, djdev->reports_supported);
> rdcat(rdesc, &rsize, hidpp_descriptor,
> sizeof(hidpp_descriptor));
Applied, thanks.
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2020-02-12 13:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 19:23 [PATCH] HID: logitech-dj: add debug msg when exporting a HID++ report descriptors Filipe Laíns
2020-01-14 1:24 ` Benjamin Tissoires
2020-01-14 1:47 ` Filipe Laíns
2020-02-12 13:45 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2002121445030.3144@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=lains@archlinux.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).