From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
linux-integrity@vger.kernel.org
Cc: Mimi Zohar <zohar@linux.ibm.com>,
Jerry Snitselaar <jsnitsel@redhat.com>,
Sumit Garg <sumit.garg@linaro.org>,
Stefan Berger <stefanb@linux.vnet.ibm.com>,
Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tpm: Detach page allocation from tpm_buf
Date: Wed, 25 Sep 2019 10:03:46 -0400 [thread overview]
Message-ID: <1569420226.3642.24.camel@HansenPartnership.com> (raw)
In-Reply-To: <20190925134842.19305-1-jarkko.sakkinen@linux.intel.com>
On Wed, 2019-09-25 at 16:48 +0300, Jarkko Sakkinen wrote:
[...]
> + data_page = alloc_page(GFP_HIGHUSER);
> + if (!data_page)
> + return -ENOMEM;
> +
> + data_ptr = kmap(data_page);
I don't think this is such a good idea. On 64 bit it's no different
from GFP_KERNEL and on 32 bit where we do have highmem, kmap space is
at a premium, so doing a highmem allocation + kmap is more wasteful of
resources than simply doing GFP_KERNEL. In general, you should only do
GFP_HIGHMEM if the page is going to be mostly used by userspace, which
really isn't the case here.
James
next prev parent reply other threads:[~2019-09-25 14:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 13:48 [PATCH] tpm: Detach page allocation from tpm_buf Jarkko Sakkinen
2019-09-25 14:03 ` James Bottomley [this message]
2019-09-27 13:06 ` Jarkko Sakkinen
2019-10-02 12:41 ` Mimi Zohar
2019-10-03 11:35 ` Jarkko Sakkinen
2019-10-03 12:50 ` Mimi Zohar
2019-10-03 18:26 ` Jarkko Sakkinen
2019-09-26 12:46 ` Jarkko Sakkinen
2019-09-26 13:12 ` Jarkko Sakkinen
2019-10-02 12:40 ` Mimi Zohar
2019-10-03 11:32 ` Jarkko Sakkinen
2019-10-03 11:33 ` Jarkko Sakkinen
2019-10-03 15:24 ` Mimi Zohar
2019-10-03 18:33 ` Jarkko Sakkinen
2019-10-03 12:39 ` Mimi Zohar
2019-10-03 18:31 ` Jarkko Sakkinen
2019-09-26 17:23 Jarkko Sakkinen
2019-09-27 15:42 ` Jarkko Sakkinen
2019-09-28 7:58 ` Jerry Snitselaar
2019-10-01 20:51 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1569420226.3642.24.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=jsnitsel@redhat.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=stefanb@linux.vnet.ibm.com \
--cc=sumit.garg@linaro.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).